Re: [ovirt-devel] Dropping rpm build from ovirt-engine check-merged.sh

----- Original Message ----- First of all, for oVirt Engine snapshot (non-release) builds, we should avoid doing a full GWT compilation [all browsers x all locales]. That's simply because the full GWT compilation is too costly for CI to run on a regular basis. Doing [Firefox + Chrome x English = 2 permutations] && [draft GWT build option enabled] for snapshot builds should be enough. The *only* downside of not doing a full GWT build is that problems with localization resources [e.g. non-English .properties files] will not be reported by the GWT compiler. But we have Java unit tests to cover this, so it should be OK. (And if not, we must improve those tests.) In general, we should do a full GWT compilation only for release builds. Eyal mentioned at [1] that his team is working on 'build official manual' option to standard CI so that would be a great place to document & perform the full GWT build. As for build jobs: if `check-merged` is indeed acting as gate for merge [fail of `check-merged` => patch not merged, `build-artifacts` does not execute], then it actually makes sense to: - keep `check-merged` doing a (draft) GWT build + Engine RPM build - maybe skip GWT build in `check-patch` [right now, there's detection logic => if frontend files were changed, do GWT build] Otherwise, if `check-merged` doesn't act as gate for merge, we can just skip GWT build / Engine RPM build for that script.