On Thu, Jun 29, 2017 at 6:16 PM, Greg Sheremeta <gshereme(a)redhat.com> wrote:
Do we have or follow a standard on patch granularity?
As a matter of fact, we have.
According to
https://www.ovirt.org/develop/dev-process/devprocess/#sending-a-patch-for...
1. Each commits contain a single logical change
2. Keep refactoring separate from bug fixes
More details on above link.
When I started, I picked up on the culture that we do small, logical
commits -- as much as possible, each commit should be focused on a specific
purpose. I've perceived some reviewers prefer to have all orthogonal
changes (fix a random spelling error, remove a duplicate semicolon)
extracted to other patches for clarity. Others don't seem to mind. I feel
like I always want to ask, but I feel bad because it's a hassle.
Also, when you are asked to extract something, do you have a trick to make
it as easy as possible?
Best wishes,
Greg
--
Greg Sheremeta, MBA
Sr. Software Engineer
Red Hat, Inc.
gshereme(a)redhat.com
_______________________________________________
Devel mailing list
Devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel
--
SANDRO BONAZZOLA
ASSOCIATE MANAGER, SOFTWARE ENGINEERING, EMEA ENG VIRTUALIZATION R&D
Red Hat EMEA <
https://www.redhat.com/>
<
https://red.ht/sig>
TRIED. TESTED. TRUSTED. <
https://redhat.com/trusted>