9:16 a.m.
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--SmQ4HENuk4Fdwsov8PNJCumIW7R9IiAQF
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
On Fri 06 Jun 2014 03:53:41 PM CEST, Nir Soffer wrote:
----- Original Message -----
> From: "Dan Kenigsberg" <danken(a)redhat.com>
> To: "Piotr Kliczewski" <piotr.kliczewski(a)gmail.com>,
fsimonce(a)redhat.c=
om, nsoffer(a)redhat.com, dcaro(a)redhat.com
> Cc: devel(a)ovirt.org
> Sent: Friday, June 6, 2014 12:15:18 PM
> Subject: Re: [ovirt-devel] local vdsm build fails
>
> On Fri, Jun 06, 2014 at 09:19:11AM +0200, Piotr Kliczewski wrote:
>> All,
>>
>> I pulled the latest vdsm from master and noticed that build is failin=
g.
>>
>> Here is the patch that causes the failuer:
>>
>> http://gerrit.ovirt.org/#/c/28226
>>
>> and looking at jenkins comments I can see that jenkins was failing
>> with the same reason:
>>
>> http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_loc=
alfs_gerrit/1064/console
Nir has already fix that as well. The storage tests were just fine, but=
a post build script was running cp incorrectly.
David pointed that we need a way to distinguish between test errors and=
failures.
He suggested looking up strings in the test output - we should not go
t=
here, unless
we want to "fix" this many more times in the future.
I suggest to use the these rules:
- SUCCESS - make check returns 0
- FAILURE - make check returns 1
- ERROR - anything else returned by make check or any other script.
I think that make check does work like this, but it should be easy to c=
hange.
What do you think?
>
> Thanks for your report. Nir has already fixed this in
> http://gerrit.ovirt.org/28426.
>
> It was introduced in http://gerrit.ovirt.org/#/c/28226/ but missed als=
o
> because we have turned PYFLAKES off in unit test jobs. We must
turn it=
on in
> at least one of the tests (or initiate a new jenkins job for
`make
> check-local`).
>
> As a quick fix, David has re-enabled PYFLAKES in
> http://jenkins.ovirt.org/view/By%20Project/view/vdsm/job/vdsm_master_u=
nit_tests/configure
>
> Regards,
> Dan.
>
Perfect for me, but you should know that it will fail also when strange=20
things occur, for example, out of memory, of disk space, slave=20
disconnected, network error, etc.
If you are willing to treat those (the most common infra failures) as=20
devel failures, then no problem on my side, but I don't want you to=20
start ignoring test errors because it's most probably an infra error=20
(don't get me wrong, it's totally normal to start ignoring an alarm=20
that is not a real problem, as infra members we will try to minimize=20
the infra issues, but it's not yet as stable as we'd like it to be).
--
David Caro
Red Hat S.L.
Continuous Integration Engineer - EMEA ENG Virtualization R&D
Email: dcaro(a)redhat.com
Web: www.redhat.com
RHT Global #: 82-62605
--SmQ4HENuk4Fdwsov8PNJCumIW7R9IiAQF
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQEcBAEBAgAGBQJTkc1UAAoJEEBxx+HSYmnDaToH/2/x5uehCP2ZiOtLZIv2t0F8
/mBzfx+rjqtIlt5wXtL+8tDJkl9lrRhd4NKwkOs6waBFmEp32XM3DNqjXLLihkgc
y9pd0opJddHv0dytmhG8mJQxzTa07momYmrb+kI1rK4VR7JiascXALwFFM5xYCIv
zx66O0nCEdPWwBEGEu6JvpbPhYlaMNjXmIxhHkPfg8r4ynIcwh8ZP1RpVMYjNft1
JE+zKsdEQdpzGfTmIpFfQ8Io0gCSlGLle65Fp84Lhw4Bl7i5SyMZI8CYKCVYe9H2
Q22MJ1mE2nhs4pvYKFrBsiMI1DZ4yzWdxzte+Rnzba12VrE3NJ2N0rNuw1/MZ9U=
=SX2o
-----END PGP SIGNATURE-----
--SmQ4HENuk4Fdwsov8PNJCumIW7R9IiAQF--