On 06/10/2012 05:11 PM, Omer Frenkel wrote:
----- Original Message -----
> From: "Michael Pasternak" <mpastern(a)redhat.com>
> To: "engine-devel" <engine-devel(a)ovirt.org>
> Sent: Sunday, June 10, 2012 4:18:14 PM
> Subject: [Engine-devel] RESTAPI: what is the purpose for /api/disks collection
>
>
> IIUC originally this collection was suppose to keep all disks
> that can be shared between different vms and/or available to be
> attached to certain vm.
>
> At the moment this collection contains all disks in system while
> engine does not provide any search capabilities for it,
>
I'm pretty sure there is search for disks, or i misunderstood you,
but you can run search query to get disks by alias and so.
it is implemented with VdcQueryType.GetAllDisks not search.
> in my view it not really useful, till we add search capabilities
> for being able:
>
> 1. locate <shareable>true</shareable> disks
this is available.
> 2. distinguish between <shareable>true|false</shareable> and
> <active>true|false</active>
> disks
> 3. maybe even worth taking
> <active>false</active>&&<shareable>false</shareable>
> out of this collection and place them under api/clusters/xxx/disks
> (or under DC).
> this way /api/disks will only have disks that can be shared.
>
> your thoughts?
>
active is not a property of a disk, but a vm-disk, as unattached floating disks has no
meaning of active.
so maybe its place is unders /api/vms/xxx/disks (IIRC its already there),
it there, but also in same time it's under /api/disks (while
<active>true</active>),
so my question is how can you know if 'floating disk' is available to be attach
to
different vm?
> --
>
> Michael Pasternak
> RedHat, ENG-Virtualization R&D
> _______________________________________________
> Engine-devel mailing list
> Engine-devel(a)ovirt.org
>
http://lists.ovirt.org/mailman/listinfo/engine-devel
>
--
Michael Pasternak
RedHat, ENG-Virtualization R&D