[ovirt-devel] Ensure processes death by terminating decorator - https://gerrit.ovirt.org/51407

Hi guys, Following the work to omit deathSignal attribute from our cpopen implementation we posted https://gerrit.ovirt.org/51407 which is ready for use. Currently locations that should use it are: (I wrote above who I expect to check the area and post a patch for that - we'll discuss it during next vdsm-sync to follow the work) shavivi: vdsm/v2v.py - in _start_virt_v2v you return aysnProc that should call kill() on fail fromani: vdsm_hooks/checkimages/before_vm_start.py - in checkImage - the code looks ok, but check if not better to use the terminating decorator.. I think it will be nicer nsoffer: vdsm/storage/mount.py - good looks ok, I prefer to use terminator there vdsm/storage/iscsiadm.py vdsm/storage/imageSharing.py vdsm/storage/hba.py -good handling, use terminator vdsm/storage/blockSD.py please check your usage with the returned process and see that you're not depending on deathSignal for it to die properly on crush some places define deathSignal for no reason, the call is sync - please remove those places: nsoffer: lib/vdsm/qemuimg.py vdsm/storage/curlImgWrap.py vdsm/storage/storage_mailbox.py vdsm/storage/misc.py fromani: lib/vdsm/virtsparsify.py ybronhei: vdsm/API.py If you can't get to it in a reasonable time, add the task to the list [1] and someone else will be it up. Please try to go over before the sync call. [1] - https://docs.google.com/spreadsheets/d/180F-C1jU54ajUn7TuR-NwrKRZY1IiZI1Z... -- *Yaniv Bronhaim.*