Re: [Engine-devel] How to validate no arg ctor existence in params?
----- Original Message -----
From: "Yair Zaslavsky" <yzaslavs(a)redhat.com>
Sent: Monday, October 7, 2013 10:15:23 AM
Yes, The patch by Vojtech should do this, can we push this forward?
once we will receive "+2" on it - we will be happy to.
@Allon: as a checkstyle expert: any chance that you can take a look
(http://gerrit.ovirt.org/#/c/18910/)?
many thanks in advance.
----- Original Message -----
> From: "Tal Nisan" <tnisan(a)redhat.com>
> To: "Einav Cohen" <ecohen(a)redhat.com>
> Cc: "Yair Zaslavsky" <yzaslavs(a)redhat.com>,
"engine-devel"
> <engine-devel(a)ovirt.org>
> Sent: Monday, October 7, 2013 5:06:52 PM
> Subject: Re: [Engine-devel] How to validate no arg ctor existence in
> params?
>
> On 10/07/2013 05:04 PM, Einav Cohen wrote:
> >> ----- Original Message -----
> >> From: "Yair Zaslavsky" <yzaslavs(a)redhat.com>
> >> Sent: Monday, October 7, 2013 10:02:39 AM
> >>
> >>
> >>
> >> ----- Original Message -----
> >>> From: "Tal Nisan" <tnisan(a)redhat.com>
> >>> To: "Yair Zaslavsky" <yzaslavs(a)redhat.com>
> >>> Cc: "engine-devel" <engine-devel(a)ovirt.org>
> >>> Sent: Monday, October 7, 2013 4:56:52 PM
> >>> Subject: Re: [Engine-devel] How to validate no arg ctor existence in
> >>> params?
> >>>
> >>> Perhaps it can be done by writing a custom checkstyle plugin? Allon
> >>> wrote one for alerting when using a static class members
initialization
> >>> in certain packages, he might know.
> >> +1
> >> Martin Perina also remembered something like that.
> >> Anyway, I strongly recommend it should be done.
> >> Already corresponding with Allon on it.
> > I might be missing something, but isn't that what patch
> > http://gerrit.ovirt.org/#/c/18910/ does?
> Seems like it, Yair I saw you also reviewed it, from a brief look at the
> code it looks like it checks for a default constructor existence as well
> as some other criterias
> >
> >>> On 10/07/2013 04:52 PM, Yair Zaslavsky wrote:
> >>>> Hi,
> >>>> I saw several patches that fixed serialization (json or gwt)
issues
> >>>> that
> >>>> were introduced due to non existence of no-arg CTOR for
parameters.
> >>>> Does anyone know a way to validate this using let's say some
jenkins
> >>>> plugin?
> >>>>
> >>>> Yair
> >>>> _______________________________________________
> >>>> Engine-devel mailing list
> >>>> Engine-devel(a)ovirt.org
> >>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
> >>>
> >> _______________________________________________
> >> Engine-devel mailing list
> >> Engine-devel(a)ovirt.org
> >> http://lists.ovirt.org/mailman/listinfo/engine-devel
> >>
> >>
> >>
>
>
_______________________________________________
Engine-devel mailing list
Engine-devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel