Re: [Engine-devel] find-bugs errors - please investigate/fix

On 04/24/2013 07:47 AM, Einav Cohen wrote: > ovirt find-bugs errors in jenkins - please investigate/fix asap. > [@Eyal - FYI: some of them seem really strange - see Michal's section below] > > @Sahina Bose: > find-bugs error details: > http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/N... > caused by: http://gerrit.ovirt.org/#/c/13831/ Have submitted a patch (http://gerrit.ovirt.org/#/c/14187/) fixing this. Thanks! > > @Michael Kublin: > find-bugs error details: > http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/N... > caused by: > http://gerrit.ovirt.org/#/c/13740/ > > @Michal Skrivanek: > > the following seem strange - can you please investigate? could be false positives. > > - find-bugs error details: > http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/N... > [not sure when introduced - seems old, hence I suspect it is a false positive] > > - Two additional errors in the same file as ^^^, you can see them at: > http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/N... > when clicking on them, there aren't any details, however according to their tool-tips, it seems to be an "unreachable > OnSuccess method within an anonymous class" or something similar. > > - another suspicious error is in VmListModel.java: > http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/N... > [again - not sure when introduced - seems old, hence I suspect it is a false positive]

> > ---- > Thanks, > Einav