On 16 Nov 2018, at 11:22, Tomasz Barański <tbaransk(a)redhat.com&gt; wrote: Hello, wise people! As a part of BZ1615830[1] I want to add information about qemu guest agent to engine's DB. I have some trouble figuring out some details. 1. VDSM seems to be using QGA, but it does not report any information about it. Am I right?

I only found a mention about it in `xml` field in JSON returned by `VM.getInfo` (and `Host.getVMFullList`): a `virtio` channel as documented in libvirt.

2. How does the engine puts data into `vm_dynamic` table? I can't find any usage for `InsertVmDynamic` procedure.

3. Also, it's not clear to me how (whether?) the engine consumes output of VM.getInfo/Host.getVMFullList.

Any pointers to relevant code appreciated. Tomo [1] https://bugzilla.redhat.com/show_bug.cgi?id=1615830 _______________________________________________ Devel mailing list -- devel(a)ovirt.org To unsubscribe send an email to devel-leave(a)ovirt.org Privacy Statement: https://www.ovirt.org/site/privacy-policy/ oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/DASVREOUEKM...

On 16 Nov 2018, at 13:21, Tomasz Baranski <tbaransk(a)redhat.com&gt; wrote: On 18/11/16 11:39, Michal Skrivanek wrote: > > >> On 16 Nov 2018, at 11:22, Tomasz Barański <tbaransk(a)redhat.com&gt; wrote: >> >> Hello, wise people! >> >> As a part of BZ1615830[1] I want to add information about qemu guest agent >> to engine's DB. I have some trouble figuring out some details. >> >> 1. VDSM seems to be using QGA, but it does not report any information about >> it. Am I right? > > what do you mean to report any information? There are guest agent reported fields which are either there or not > One such field is appsList which returns the agent itself (well, it’s fake for qemu-ga, but the agent string is always put there) Oh, appsList, I didn't look into stats. Thanks, I guess that's what I was looking for. > >> I only found a mention about it in `xml` field in JSON returned by >> `VM.getInfo` (and `Host.getVMFullList`): a `virtio` channel as >> documented in libvirt. > > virtio channels are always there for both agents > >> >> 2. How does the engine puts data into `vm_dynamic` table? I can't find any >> usage for `InsertVmDynamic` procedure. > > app_list ?? How is app_list used to fill in fields like `vnc_port` or `cpu_name`?

> >> >> 3. Also, it's not clear to me how (whether?) the engine consumes output of >> VM.getInfo/Host.getVMFullList. > > it does not in 4.2+ clusters, see FullListAdapter::getVmFullList() > > HTH, > michal > >> Any pointers to relevant code appreciated. >> >> >> Tomo >> [1] https://bugzilla.redhat.com/show_bug.cgi?id=1615830 >> _______________________________________________ >> Devel mailing list -- devel(a)ovirt.org >> To unsubscribe send an email to devel-leave(a)ovirt.org >> Privacy Statement: https://www.ovirt.org/site/privacy-policy/ >> oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ >> List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/DASVREOUEKM... >

On Fri, 16 Nov 2018 at 17:09, Michal Skrivanek <michal.skrivanek(a)redhat.com&gt; wrote: > > > > On 16 Nov 2018, at 13:21, Tomasz Baranski <tbaransk(a)redhat.com&gt; wrote: > > > > On 18/11/16 11:39, Michal Skrivanek wrote: > >> > >> > >>> On 16 Nov 2018, at 11:22, Tomasz Barański <tbaransk(a)redhat.com&gt; wrote: > >>> > >>> Hello, wise people! > >>> > >>> As a part of BZ1615830[1] I want to add information about qemu guest > agent > >>> to engine's DB. I have some trouble figuring out some details. > >>> > >>> 1. VDSM seems to be using QGA, but it does not report any information > about > >>> it. Am I right? > >> > >> what do you mean to report any information? There are guest agent > reported fields which are either there or not > >> One such field is appsList which returns the agent itself (well, it’s > fake for qemu-ga, but the agent string is always put there) > > > > Oh, appsList, I didn't look into stats. > > Thanks, I guess that's what I was looking for. > > > >> > >>> I only found a mention about it in `xml` field in JSON returned by > >>> `VM.getInfo` (and `Host.getVMFullList`): a `virtio` channel as > >>> documented in libvirt. > >> > >> virtio channels are always there for both agents > >> > >>> > >>> 2. How does the engine puts data into `vm_dynamic` table? I can't find > any > >>> usage for `InsertVmDynamic` procedure. > >> > >> app_list > > > > ?? > > How is app_list used to fill in fields like `vnc_port` or `cpu_name`? > > oh sorry, I though you still talk about the guest agent info only > VmDynamic::updateRuntimeData() > > Look at VmsMonitoring::flush() method. The VmDynamic, VmStatistics and other fields are stored to the DB there.