Re: [ovirt-devel] [Fixed][vdsm] Failing to rename volume on merge (remove snapshot operation)

Sunday, 8 May 2016

On Sun, May 8, 2016 at 4:11 PM, Maor Lipchuk <mlipchuk(a)redhat.com&gt; wrote:

...

 On Sun, May 8, 2016 at 2:22 PM, Nir Soffer <nsoffer(a)redhat.com&gt; wrote:

> On Sun, May 8, 2016 at 12:56 PM, Maor Lipchuk <mlipchuk(a)redhat.com&gt;
> wrote:
> > Hi,
> >
> > I've been trying to remove a single snapshot and consistently fail with
> the
> > following error (see [1]).
> >
> > Those are my steps:
> > 1. Create a VM + Disk
> > 2. Create a snapshot
> > 3. Remove the snapshot
> >
> > My VDSM is the latest (commit d7796fb8bdd5b424ecad54dc36cb58cd477b3224)
> >
> > Is there a bug open on it? or even better, fixing patches?
> >
> > [1]
> > 5b61867b-6dd4-4224-be4a-859904e3298b::DEBUG::2016-05-08
> > 12:34:22,296::fileVolume::573::Storage.Volume::(rename) Renaming
> > /rhev/data-center/mnt/10.35.16.43:_export_data9/e562ec63-b734-4554-b8
> >
>
2c-7fc8314c352f/images/c26b2f00-563f-4965-8bcd-e7ca8ead1625/903f5a13-f7e4-4222-bb02-303019756bb9.lease
> > to
> > /rhev/data-center/mnt/10.35.16.43:
> _export_data9/e562ec63-b734-4554-b82c-7fc8314c352f
> >
>
/images/c26b2f00-563f-4965-8bcd-e7ca8ead1625/_remove_me_LGQXBkpd_903f5a13-f7e4-4222-bb02-303019756bb9.lease
> > 5b61867b-6dd4-4224-be4a-859904e3298b::ERROR::2016-05-08
> > 12:34:22,298::image::1338::Storage.Image::(merge) can't set attribute
> > Traceback (most recent call last):
> >   File "/usr/share/vdsm/storage/image.py", line 1321, in merge
> >     [vols[vName] for vName in chain])
> >   File "/usr/share/vdsm/storage/image.py", line 1146, in
> _baseRawVolumeMerge
> >     srcVol.rename(tmpUUID)
> >   File "/usr/share/vdsm/storage/fileVolume.py", line 580, in rename
> >     self._manifest.volumePath = volPath
> > AttributeError: can't set attribute
>
> I think this is a bug introduced during the sdm refactorings, and I
> also reproduced it once
> but did not have time to investigate it yet.
>
> If the code expect the replace a volume path during runtime, we should
> have a setter:
>
> @property
> def volumePath(self):
>     return self._volumePath
>
> @volumePath.setter
> def volumePath(self, value):
>     self._volumePath = value
>
> You can try add this to the manifest class and see if it fixes this issue.
>

 Looks like that fixes the issue.
Added a patch at https://gerrit.ovirt.org/#/c/57194/1

Thanks for the help,
Maor

...

>
>>
>> Nir
>>
>> > 5b61867b-6dd4-4224-be4a-859904e3298b::DEBUG::2016-05-08
>> >
>> 12:34:22,299::resourceManager::628::Storage.ResourceManager::(releaseResource)
>> > Trying to release resource 'e562ec63-b734-4554-b82c-7fc
>> > 8314c352f_imageNS.c26b2f00-563f-4965-8bcd-e7ca8ead1625'
>> > 5b61867b-6dd4-4224-be4a-859904e3298b::DEBUG::2016-05-08
>> >
>> 12:34:22,299::resourceManager::647::Storage.ResourceManager::(releaseResource)
>> > Released resource 'e562ec63-b734-4554-b82c-7fc8314c352f
>> > _imageNS.c26b2f00-563f-4965-8bcd-e7ca8ead1625' (0 active users)
>> > 5b61867b-6dd4-4224-be4a-859904e3298b::DEBUG::2016-05-08
>> >
>> 12:34:22,299::resourceManager::653::Storage.ResourceManager::(releaseResource)
>> > Resource 'e562ec63-b734-4554-b82c-7fc8314c352f_imageNS.
>> > c26b2f00-563f-4965-8bcd-e7ca8ead1625' is free, finding out if anyone is
>> > waiting for it.
>> > 5b61867b-6dd4-4224-be4a-859904e3298b::DEBUG::2016-05-08
>> >
>> 12:34:22,299::resourceManager::628::Storage.ResourceManager::(releaseResource)
>> > Trying to release resource 'e562ec63-b734-4554-b82c-7fc
>> > 8314c352f_volumeNS.903f5a13-f7e4-4222-bb02-303019756bb9'
>> > 5b61867b-6dd4-4224-be4a-859904e3298b::DEBUG::2016-05-08
>> >
>> 12:34:22,299::resourceManager::647::Storage.ResourceManager::(releaseResource)
>> > Released resource 'e562ec63-b734-4554-b82c-7fc8314c352f
>> > _volumeNS.903f5a13-f7e4-4222-bb02-303019756bb9' (0 active users)
>> > 5b61867b-6dd4-4224-be4a-859904e3298b::DEBUG::2016-05-08
>> >
>> 12:34:22,299::resourceManager::653::Storage.ResourceManager::(releaseResource)
>> > Resource 'e562ec63-b734-4554-b82c-7fc8314c352f_volumeNS
>> > .903f5a13-f7e4-4222-bb02-303019756bb9' is free, finding out if anyone
is
>> > waiting for it.
>> > 5b61867b-6dd4-4224-be4a-859904e3298b::DEBUG::2016-05-08
>> >
>> 12:34:22,299::resourceManager::661::Storage.ResourceManager::(releaseResource)
>> > No one is waiting for resource 'e562ec63-b734-4554-b82c
>> > -7fc8314c352f_volumeNS.903f5a13-f7e4-4222-bb02-303019756bb9', Clearing
>> > records.
>> > 5b61867b-6dd4-4224-be4a-859904e3298b::DEBUG::2016-05-08
>> >
>> 12:34:22,299::resourceManager::628::Storage.ResourceManager::(releaseResource)
>> > Trying to release resource 'e562ec63-b734-4554-b82c-7fc
>> > 8314c352f_volumeNS.e6d9874a-8225-44e1-9440-0a3cfd4ea7fc'
>> > 5b61867b-6dd4-4224-be4a-859904e3298b::DEBUG::2016-05-08
>> >
>> 12:34:22,299::resourceManager::647::Storage.ResourceManager::(releaseResource)
>> > Released resource 'e562ec63-b734-4554-b82c-7fc8314c352f
>> > _volumeNS.e6d9874a-8225-44e1-9440-0a3cfd4ea7fc' (0 active users)
>> > 5b61867b-6dd4-4224-be4a-859904e3298b::DEBUG::2016-05-08
>> >
>> 12:34:22,300::resourceManager::653::Storage.ResourceManager::(releaseResource)
>> > Resource 'e562ec63-b734-4554-b82c-7fc8314c352f_volumeNS
>> > .e6d9874a-8225-44e1-9440-0a3cfd4ea7fc' is free, finding out if anyone
is
>> > waiting for it.
>> > 5b61867b-6dd4-4224-be4a-859904e3298b::DEBUG::2016-05-08
>> >
>> 12:34:22,300::resourceManager::661::Storage.ResourceManager::(releaseResource)
>> > No one is waiting for resource 'e562ec63-b734-4554-b82c
>> > -7fc8314c352f_volumeNS.e6d9874a-8225-44e1-9440-0a3cfd4ea7fc', Clearing
>> > records.
>> > 5b61867b-6dd4-4224-be4a-859904e3298b::DEBUG::2016-05-08
>> >
>> 12:34:22,300::resourceManager::661::Storage.ResourceManager::(releaseResource)
>> > No one is waiting for resource 'e562ec63-b734-4554-b82c
>> > -7fc8314c352f_imageNS.c26b2f00-563f-4965-8bcd-e7ca8ead1625', Clearing
>> > records.
>> > 5b61867b-6dd4-4224-be4a-859904e3298b::ERROR::2016-05-08
>> > 12:34:22,300::task::868::Storage.TaskManager.Task::(_setError)
>> > Task=`5b61867b-6dd4-4224-be4a-859904e3298b`::Unexpected error
>> > Traceback (most recent call last):
>> >   File "/usr/share/vdsm/storage/task.py", line 875, in _run
>> >     return fn(*args, **kargs)
>> >   File "/usr/share/vdsm/storage/task.py", line 334, in run
>> >     return self.cmd(*self.argslist, **self.argsdict)
>> >   File
"/usr/lib/python2.7/site-packages/vdsm/storage/securable.py",
>> line
>> > 78, in wrapper
>> >     return method(self, *args, **kwargs)
>> >   File "/usr/share/vdsm/storage/sp.py", line 1862, in
mergeSnapshots
>> >     sdUUID, vmUUID, imgUUID, ancestor, successor, postZero)
>> >   File "/usr/share/vdsm/storage/image.py", line 1339, in merge
>> > :    raise se.SourceImageActionError(imgUUID, sdUUID, str(e))
>> > SourceImageActionError: Error during source image manipulation:
>> > "image=c26b2f00-563f-4965-8bcd-e7ca8ead1625, source
>> > domain=e562ec63-b734-4554-b82c-7fc8314c352f: can't set attribute"
>> > 5b61867b-6dd4-4224-be4a-859904e3298b::DEBUG::2016-05-08
>> > 12:34:22,300::task::887::Storage.TaskManager.Task::(_run)
>> > Task=`5b61867b-6dd4-4224-be4a-859904e3298b`::Task._run:
>> > 5b61867b-6dd4-4224-be4a-859904e3298b () {} failed - stopping task
>> > 5b61867b-6dd4-4224-be4a-859904e3298b::DEBUG::2016-05-08
>> > 12:34:22,300::task::1248::Storage.TaskManager.Task::(stop)
>> > Task=`5b61867b-6dd4-4224-be4a-859904e3298b`::stopping in state running
>> > (force False)
>> >
>> >
>> >
>> > Regards,
>> > Maor
>> >
>> >
>> > _______________________________________________
>> > vdsm-devel mailing list
>> > vdsm-devel(a)lists.fedorahosted.org
>> >
>> https://lists.fedorahosted.org/admin/lists/vdsm-devel@lists.fedorahosted.org
>> >
>...

 >

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011