On Mon, 25 Feb 2019, 20:52 Nir Soffer, <nsoffer(a)redhat.com&gt; wrote: > Hi all, > > I learned recently that we have these groups in the project: > vdsm-maintainers: https://gerrit.ovirt.org/#/admin/groups/15,members > vdsm-master-maintainers: > https://gerrit.ovirt.org/#/admin/groups/106,members > > And we have this complicated access control list: > https://gerrit.ovirt.org/#/admin/projects/vdsm,access > > Developers in vdsm-master-maintainers can approve patches, but cannot > submit. > I find this strange and more complicated than needed. I think we can > trust people > in the vdsm-master-maintainers group to do the right thing. > > I sent this patch to simplify the ACL (with help of Gerrit UI): > https://gerrit.ovirt.org/c/97738/ > > Thoughts? > I don't recall the origin of this differentiation, and I'd rather simplify it. It makes simple sense that vdsm-master-maintainers are in full control of the master branch of vdsm. +1 from me.