10:49 p.m.
On Thu, Mar 16, 2017 at 8:16 PM, Michal Skrivanek <mskrivan(a)redhat.com>
wrote:
On 16 Mar 2017, at 15:18, Yaniv Kaul <ykaul(a)redhat.com> wrote:
On Thu, Mar 16, 2017 at 10:46 AM, Nir Soffer <nsoffer(a)redhat.com> wrote:
> If found this error in system tests - looks like wrong assert - code
> should check
> if disk is not None before checking state.
>
> I'm not sure who is the owner of this test, so posting here.
>
Theoretically, perhaps.
Practically, it worked (until yesterday?) and now I'm also seeing this
failure - it's not a coincidence.
However, looking at my failure[1], I'm seeing other nasty stuff, which may
explain the later on failures
For example, new NPE I have not seen in the past:
2017-03-16 09:57:57,581-04 INFO [org.ovirt.engine.core.bll.AddVmTemplateCommand]
(DefaultQuartzScheduler1) [5d94233] Ending command
'org.ovirt.engine.core.bll.AddVmTemplateCommand' successfully.
Is this IST or which TZ?
Interesting question - I guess that's why we need the offset from UTC or
use UTC in the logs.
Likely https://gerrit.ovirt.org/#/c/69323 merged 10:33:20 CET today
That's the cause or the fix?
Y.
2017-03-16 09:57:57,591-04 INFO [org.ovirt.engine.core.vdsbroker.SetVmStatusVDSCommand]
(DefaultQuartzScheduler1) [5d94233] START, SetVmStatusVDSCommand(
SetVmStatusVDSCommandParameters:{runAsync='true',
vmId='00000000-0000-0000-0000-000000000000', status='Down',
exitStatus='Normal'}), log id: 30ee3299
2017-03-16 09:57:57,593-04 DEBUG [org.ovirt.engine.core.dal.dbbroker.
PostgresDbEngineDialect$PostgresSimpleJdbcCall] (DefaultQuartzScheduler1)
[5d94233] Compiled stored procedure. Call string is [{call
getvmdynamicbyvmguid(?)}]
2017-03-16 09:57:57,594-04 DEBUG [org.ovirt.engine.core.dal.dbbroker.
PostgresDbEngineDialect$PostgresSimpleJdbcCall] (DefaultQuartzScheduler1)
[5d94233] SqlCall for procedure [GetVmDynamicByVmGuid] compiled
2017-03-16 09:57:57,595-04 ERROR [org.ovirt.engine.core.vdsbroker.SetVmStatusVDSCommand]
(DefaultQuartzScheduler1) [5d94233] Command 'SetVmStatusVDSCommand(
SetVmStatusVDSCommandParameters:{runAsync='true',
vmId='00000000-0000-0000-0000-000000000000', status='Down',
exitStatus='Normal'})' execution failed: null
2017-03-16 09:57:57,595-04 DEBUG [org.ovirt.engine.core.vdsbroker.SetVmStatusVDSCommand]
(DefaultQuartzScheduler1) [5d94233] Exception:
java.lang.NullPointerException
at org.ovirt.engine.core.vdsbroker.SetVmStatusVDSCommand.
executeVDSCommand(SetVmStatusVDSCommand.java:33) [vdsbroker.jar:]
at org.ovirt.engine.core.vdsbroker.VDSCommandBase.
executeCommand(VDSCommandBase.java:73) [vdsbroker.jar:]
at org.ovirt.engine.core.dal.VdcCommandBase.execute(VdcCommandBase.java:33)
[dal.jar:]
at org.ovirt.engine.core.vdsbroker.vdsbroker.DefaultVdsCommandExecutor.
execute(DefaultVdsCommandExecutor.java:14) [vdsbroker.jar:]
at org.ovirt.engine.core.vdsbroker.ResourceManager.
runVdsCommand(ResourceManager.java:404) [vdsbroker.jar:]
at
org.ovirt.engine.core.bll.VDSBrokerFrontendImpl.runVdsCommand(VDSBrokerFrontendImpl.java:33)
[bll.jar:]
at org.ovirt.engine.core.bll.VmHandler.unLockVm(VmHandler.java:377)
[bll.jar:]
Y.
[1] http://jenkins.ovirt.org/job/ovirt-system-tests_master_
check-patch-el7-x86_64/326/artifact/exported-artifacts/
basic_suite_master__logs/test_logs/basic-suite-master/post-
004_basic_sanity.py/lago-basic-suite-master-engine/_
var_log/ovirt-engine/engine.log
> *08:28:05* # snapshots_merge: *08:28:31* Unhandled exception in <function
<lambda> at 0x276a5f0>*08:28:31* Traceback (most recent call last):*08:28:31*
File "/usr/lib/python2.7/site-packages/ovirtlago/testlib.py", line 217, in
assert_equals_within*08:28:31* res = func()*08:28:31* File
"/home/jenkins/workspace/ovirt-system-tests_manual/ovirt-system-tests/basic-suite-master/test-scenarios/004_basic_sanity.py",
line 466, in <lambda>*08:28:31*
api.vms.get(VM0_NAME).disks.get(disk_name).status.state == 'ok'*08:28:31*
AttributeError: 'NoneType' object has no attribute 'state'*08:28:31* Error
while running thread*08:28:31* Traceback (most recent call last):*08:28:31* File
"/usr/lib/python2.7/site-packages/lago/utils.py", line 57, in
_ret_via_queue*08:28:31* queue.put({'return': func()})*08:28:31* File
"/home/jenkins/workspace/ovirt-system-tests_manual/ovirt-system-tests/basic-suite-master/test-scenarios/004_basic_sanity.py",
line 465, in snapshot_live_merge*08:28:31* lambda:*08:28:31* File
"/usr/lib/python2.7/site-packages/ovirtlago/testlib.py", line 264, in
assert_true_within_long*08:28:31* assert_equals_within_long(func, True,
allowed_exceptions)*08:28:31* File
"/usr/lib/python2.7/site-packages/ovirtlago/testlib.py", line 251, in
assert_equals_within_long*08:28:31* func, value, LONG_TIMEOUT,
allowed_exceptions=allowed_exceptions*08:28:31* File
"/usr/lib/python2.7/site-packages/ovirtlago/testlib.py", line 217, in
assert_equals_within*08:28:31* res = func()*08:28:31* File
"/home/jenkins/workspace/ovirt-system-tests_manual/ovirt-system-tests/basic-suite-master/test-scenarios/004_basic_sanity.py",
line 466, in <lambda>*08:28:31*
api.vms.get(VM0_NAME).disks.get(disk_name).status.state == 'ok'*08:28:31*
AttributeError: 'NoneType' object has no attribute 'state'
>
>
>
> _______________________________________________
> Devel mailing list
> Devel(a)ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>
_______________________________________________
Devel mailing list
Devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel