Re: [Engine-devel] Unifying (parts of) commit templates.
----- Original Message -----
From: "Livnat Peer" <lpeer(a)redhat.com>
To: "Itamar Heim" <iheim(a)redhat.com>
Cc: engine-devel(a)ovirt.org
Sent: Thursday, August 9, 2012 11:54:38 AM
Subject: Re: [Engine-devel] Unifying (parts of) commit templates.
On 09/08/12 11:52, Itamar Heim wrote:
> On 08/09/2012 09:11 AM, Livnat Peer wrote:
>> On 09/08/12 00:41, Doron Fediuck wrote:
>>> Hi All,
>>> It seems that for commit subjects, vdsm is using a general
>>> concept of-
>>>
>>> BZ#??????? some message
>>>
>>> I'd like to suggest adopting it to the engine template we use
>>> today-
>>>
>>> BZ#??????? <core | restapi | tools | history | engine |
>>> userportal |
>>> webadmin>: short summary under 50 chars
>>>
>>> This may help us write some scripts which will work both for vdsm
>>> and
>>> engine BZs.
>>>
>>
>> +1
>> with a small change - adding a \n after the bz number -
>
> wouldn't this kill git shortlog?
> patch short summary must be in first line iirc
>
yes it will.
+1 for Doron's initial proposal
+1.
Also, while we're at it, a wiki explaining the correct way to use this template would
be great.
I know, it's pretty straight forward, but new contributed may get confused as to the
distinction between core and engine, or how to mark a vertical patch that fixes a UI
dialog and the backend logic behind it (with a coma between components? a slash? a pipe?)
>> BZ#???????
>> <core | restapi | tools | history | engine | userportal |
>> webadmin>:
>> short summary under 50 chars
>>
>> Long description of what this commit is about
>>
>> Livnat
>>
>>> Doron.
>>> _______________________________________________
>>> Engine-devel mailing list
>>> Engine-devel(a)ovirt.org
>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>>
>>
>> _______________________________________________
>> Engine-devel mailing list
>> Engine-devel(a)ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>
>
>
_______________________________________________
Engine-devel mailing list
Engine-devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel