On 06/10/2012 06:52 PM, Itamar Heim wrote:
On 06/10/2012 06:35 PM, Omer Frenkel wrote:
if so why it appear in /disks?, i think root collection /disks should contain only items available for common usage. (can't see any point in showing private vm disks there (such as not-shareable&& not-floating))
i don't think it makes sense a disk will go away to a user from /disks once it was attached, etc.
it's exactly the behaviour i'd like to achieve (only disks available for common usage shown), if you attached it to vm X and want detach it, go to vm/xx/disks/yy and detach it there, (btw if we want support showing all disks in /disks, we should have link from the disk->vm it attached to.)
why not show here all disks?
the use-case is client-side filtering, in sdk i provide this capability where it's not supported by ovirt-search (such as property based filtering etc.), getting big chunk of not relevant data, is show-stopper for this feature. in my other email, i suggested adding search-parameter for being able requesting extended list, while the default should be reduced.
well i guess its a way of looking at it, personally i think that there is no reason blocking data from the user, let the user decide if he would like to see all disks, or filter it with a simple query.
you mentioned common usage, private templates also return in /templates, no? no one can use them but one user. maybe im the storage guy, and my 'usage' in the disks tab is to see how people are handling disks and storage (probably not so good example but just trying to say don't hide info from the users, you don't know all the use cases)
not sure this is the same: private template will not show to a user without relevant permissions via the user api. admin api shows all objects, hence the private template as well.
-- Michael Pasternak RedHat, ENG-Virtualization R&D