On Sat, May 28, 2016 at 03:16:10PM +0300, Nir Soffer wrote:
Hi all,
We have several scripts spread in the source, typically installed in
/usr/libexec/vdsm.
We had a useless WHITELIST[1], trying to compile these scripts with python3, and
we have similar (but working) whitelist for pyflakes and pep8.
To simplify the various checks, I think we need to to do this:
1. Keep .py suffix for all python files
2. Move all scripts to helpers/ ([2] handles storage scripts)
3. During installation, strip the .py suffix.
With these changes, we can use the various checking commands on the entire
source tree.
For example, these commands check the entire tree:
PYTHONDONTWRITEBYTECODE=1 python3 -m compileall -f -x '(\.tox/|\.git/)' .
pep8 .
pyflakes .
Thoughts?
[1]
https://gerrit.ovirt.org/58204
[2]
https://gerrit.ovirt.org/57363
Sounds good, though I'd love to keep the separation of scripts into
their natuaral vertical. Keep storage understand storage, etc. Why are
you piling them into one source directory?