--tpyx7gKuSYt+mjHM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 03/30 11:45, Roy Golan wrote:
Hi all, =20 Eyal and I sat together to analyse and tweak the engine CI and this is wh= at we came up with: =20 - dao test excludes updated - exclude dal/src/main/bundles from invoking dao tests A trivial update of validation messages without any db change would trigger dao test without any need. This is one less job run for lots of patches. This change is effective now.
I really recommend merging this into the standard ci scripts and doing the trigger/don't trigger stuff there
=20 - Spare CI re-run on trivial rebases Gerrit trigger supports suppressing itself if the change to the tree was trivial. Most of the waste of resources(time and IO :) ) is around rebasing a change and waiting for CI to rerun. if Change1 is ci+1 and Change2 is ci+1 the chances that they will break CI together is very small and taking that risk is most probably worth it due to the huge resources waste
This is not exactly how it works, trivial rebases don't care if the previous patch had ci+1 or not, it just means that the rebase did not get any confli= cts, that most of the time is not related to the tests working or not (it might = be that someone change a method on another file, that your patch is using and = it will be a trivial rebase and break the tests/compile). I don't really recommend skipping them. What you might meant is non-code changes, those are changes that only change the commit message, for example= , if you have a patch, and you want to fix a typo in the commit message, current= ly that small commit message fix will require and trigger a ci run, while when skipping the non-code changes, it will not needed.
This change isn't effective yet - *Please reply here* if you agree or n= ot to make this change available. =20 All of this is 'master' - 3.6 will follow if we will agree on activating that change. =20 Thanks, Roy
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
--=20 David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Tel.: +420 532 294 605 Email: dcaro@redhat.com IRC: dcaro|dcaroest@{freenode|oftc|redhat} Web: www.redhat.com RHT Global #: 82-62605 --tpyx7gKuSYt+mjHM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJW+5TIAAoJEEBxx+HSYmnDbP8IAJkxIztpyvtCWlnQytV4HgQY x/Wq/K797i/8aMPSO9MKEc10QhYpdB0CoO8+n1Isak6LoE0G44+tFSnaWBHGaw0N 07FhPB+ye99eagiyUKPyENK8h5Xkth9xYDGJHIpLi1CReT4DQtIDGzGtCUQpSDuI KNzmpKdHDpoI5VxArHZVAynF7ifa6HvDCm8273cy1Ul5qmNFMaIi3D13OBaV6yRS VVpm5XMjq7OHbO8fWgwwU3hMDSTkWWxV0Y6G8ClQM9YtRFEtLeJg2whaMRIf1mgB vlLHut1aE0Hh/Gqr2taidhdscT8bgV1O8ZR2mXCG0zMpEwBWqVcXCkUlyfRE+Gk= =E2ZD -----END PGP SIGNATURE----- --tpyx7gKuSYt+mjHM--