[ovirt-devel] Re: Need help in handling catch block in vdsm

On 29 Sep 2020, at 09:51, Ritesh Chikatwar <rchikatw(a)redhat.com&gt; wrote: Hello, i am new to VDSM codebase. There is one minor bug in gluster and they don't have any near plan to fix this. So i need to fix this in vdsm. The bug is when i run command [root@dhcp35-237 ~]# gluster v geo-replication status No active geo-replication sessions geo-replication command failed [root@dhcp35-237 ~]# So this engine is piling up with error. i need handle this in vdsm the code at this place https://github.com/oVirt/vdsm/blob/master/lib/vdsm/gluster/cli.py#L1231 <https://github.com/oVirt/vdsm/blob/master/lib/vdsm/gluster/cli.py#L1231> If i run the above command with xml then i will get [root@dhcp35-237 ~]# gluster v geo-replication status --xml geo-replication command failed [root@dhcp35-237 ~]# so i have to run one more command before executing this and check in exception that it contains No active geo-replication sessions this string. for that i did like this

try: xmltree = _execGluster(command) except ge.GlusterCmdFailedException as e: if str(e).find("No active geo-replication sessions") != -1: return [] Seems like this is not working can you help me here Any help will be appreciated Ritesh