2:40 a.m.
Thanks for pointing that out. Right now the only isssue is upgrading
tox
I guess.
yes. Fedora provides only 3.5, so you need to upgrade it via pip (and make
sure you use one installed via pip and not from package if you previously
installed it)
```
[kmajumde:~/work/git/vdsm] master+* 2 ± make check
Makefile:1029: warning: overriding recipe for target 'check-recursive'
Makefile:548: warning: ignoring old recipe for target 'check-recursive'
Checking that .in files are ignored...
! git --no-pager grep execCmd `git ls-files | grep -v -F -f
execcmd-blacklist.txt`
out=`tox --version`; \
if [ $? -ne 0 ]; then \
echo "Error: cannot run tox, please install tox \
3.14 or later"; \
exit 1; \
fi; \
version=`echo $out | cut -d' ' -f1`; \
if python2.7 build-aux/vercmp $version 3.14; then \
echo "Error: tox is too old, please install tox \
3.14 or later"; \
exit 1; \
fi
Error: tox is too old, please install tox 3.14 or later
make: *** [Makefile:1012: tox] Error 1
```
On Mon, Oct 14, 2019 at 10:42 PM Benny Zlotnik <bzlotnik(a)redhat.com> wrote:
> did you run autogen.sh?
>
> On Mon, Oct 14, 2019 at 7:12 PM Kaustav Majumder <kmajumde(a)redhat.com>
>
> wrote:
> > Yes i did but same issue.
> >
> > On Mon, Oct 14, 2019 at 7:55 PM Marcin Sobczyk <msobczyk(a)redhat.com>
>
> wrote:
> >> Hi,
> >>
> >> On 10/14/19 3:06 PM, Kaustav Majumder wrote:
> >>
> >>
> >> Hi,
> >> I am having an issue running make check on vdsm master.
> >>
> >> `
> >> if [ -n "$NOSE_WITH_COVERAGE" ]; then \
> >>
> >> mv .coverage .coverage-nose-py27; \
> >>
> >> fi
> >>
> >> Traceback (most recent call last):
> >> File "../tests/testrunner.py", line 70, in <module>
> >>
> >> from vdsm import constants
> >>
> >> File "/home/kmajumde/work/git/vdsm/lib/vdsm/constants.py", line
29,
>
> in <module>
>
> >> from vdsm.common.constants import * # NOQA: F401, F403
> >>
> >> `
> >> Am I missing something? Do I need to run tests differently?
> >>
> >> did you run plane 'make' before 'make check'?
> >>
> >> --
> >>
> >> Thanks,
> >>
> >> Kaustav Majumder
> >>
> >>
> >> _______________________________________________
> >> Devel mailing list -- devel(a)ovirt.org
> >> To unsubscribe send an email to devel-leave(a)ovirt.org
> >> Privacy Statement: https://www.ovirt.org/site/privacy-policy/
>
> >> oVirt Code of Conduct:
> https://www.ovirt.org/community/about/community-guidelines/
>
> >> List Archives:
> https://lists.ovirt.org/archives/list/devel@ovirt.org/message/MTWRVTRJ5DLD
> VOWHW6RZWBLMETZ3NYCM/>
> > --
> >
> > Thanks,
> >
> > Kaustav Majumder
> >
> > _______________________________________________
> > Devel mailing list -- devel(a)ovirt.org
> > To unsubscribe send an email to devel-leave(a)ovirt.org
> > Privacy Statement: https://www.ovirt.org/site/privacy-policy/
>
> > oVirt Code of Conduct:
> https://www.ovirt.org/community/about/community-guidelines/
>
> > List Archives:
> https://lists.ovirt.org/archives/list/devel@ovirt.org/message/7R35UEDCP4WE
> LAQT5EHG6U72LWQFUGSK/