----- Original Message -----
From: "Igor Lvovsky" <ilvovsky@redhat.com> To: "Simon Grinberg" <simon@redhat.com> Cc: "Dan Yasny" <dyasny@redhat.com>, "engine-devel" <engine-devel@ovirt.org>, "vdsm-devel" <vdsm-devel@lists.fedorahosted.org> Sent: Wednesday, October 10, 2012 5:27:13 PM Subject: Re: [Engine-devel] Network related hooks in vdsm
----- Original Message -----
From: "Simon Grinberg" <simon@redhat.com> To: "Igor Lvovsky" <ilvovsky@redhat.com> Cc: "Dan Yasny" <dyasny@redhat.com>, "vdsm-devel" <vdsm-devel@lists.fedorahosted.org>, "engine-devel" <engine-devel@ovirt.org> Sent: Wednesday, October 10, 2012 5:03:52 PM Subject: Re: [Engine-devel] Network related hooks in vdsm
----- Original Message -----
From: "Igor Lvovsky" <ilvovsky@redhat.com> To: "vdsm-devel" <vdsm-devel@lists.fedorahosted.org>, "engine-devel" <engine-devel@ovirt.org> Cc: "Dan Yasny" <dyasny@redhat.com> Sent: Wednesday, October 10, 2012 4:47:28 PM Subject: [Engine-devel] Network related hooks in vdsm
Hi everyone, As you know vdsm has hooks mechanism and we already support dozen of hooks for different needs. Now it's a network's time. We would like to get your comments regarding our proposition for network related hooks.
In general we are planning to prepare framework for future support of bunch network related hooks. Some of them already proposed by Itzik Brown [1] and Dan Yasny [2].
Below you can find the additional hooks list that we propose:
Note: In the first stage we can implement these hooks without any parameters, just to provide an entry point for simple hooks.
Networks manipulation: - before_add_network(conf={}, customProperty={}) - after_add_network(conf={}, customProperty={}) - before_del_network(conf={}, customProperty={}) - after_del_network(conf={}, customProperty={}) - before_edit_network(conf={}, customProperty={}) - after_edit_network(conf={}, customProperty={}) - TBD
+ VM networking related points in addition to before/after vm start/stop before_hotplug_nic(conf={}, customProperty={}) *after_hotplug_nic(conf={}, customProperty={}) before_hotunplug_nic(conf={}, customProperty={}) *after_hotunplug_nic(conf={}, customProperty={})
* Not sure about use case for those two
Yep, part of them already proposed by Itzik (look at [1])
This is what happen when you miss out the end of the email :) But if I'm reading the comment correctly it indeed doesn't implement two of the 4 above. My '*' was in the wrong location, indeed the two suggested in the patch are the two I can find a use case for, while the other two I'm not sure of but I think should be implemented for completeness.
The above will require VM IDs and networks? Sorry that I did not look into the actual implementation of the above naming is more of a guess work, but I think the meaning is clear. There may be other VM networking related entry points I've missed.
Bondings manipulations: - before_add_bond(conf={}, customProperty={}) - after_add_bond(conf={}, customProperty={}) - before_del_bond(conf={}, customProperty={}) - after_del_bond(conf={}, customProperty={}) - before_edit_bond(conf={}, customProperty={}) - after_edit_bond(conf={}, customProperty={}) - TBD
General purpose: - before_persist_network - after_persist_network
Now we just need to figure out the use cases.
Your input more than welcome...
[1] http://gerrit.ovirt.org/#/c/7224/ - Adding hooks support for NIC hotplug [2] http://gerrit.ovirt.org/#/c/7547/ - Hook: Cisco VM-FEX support
Regards, Igor Lvovsky _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel