On Wed, Jul 22, 2015 at 4:59 PM, Douglas Schilling Landgraf
<dougsland(a)redhat.com> wrote:
On 07/22/2015 09:42 AM, Fabian Deutsch wrote:
>
> Hey,
>
> I've seen that some new code landed to support Engine registration
> using the generic registration approach.
>
> But it seem that we now have two implementations:
>
> 1. vdsm-tool register [0]
> 2. ovirt-register [1]
>
> To reduce code duplication I'd suggest to drop one of these approaches
> before we enter 3.6.
> Or are there reasons for keeping both of them?
I believe not.
Great.
> My take is to keep ovirt-register which is independent and would
allow
> us to add plain hosts to Engine (host-deploy is then taking care of
> the rest IIUIC).
> The vdsm-tool approach reuqires vdsm to be installed.
>
> Thoughts?
+1 for dropping vdsm-tool register verb. It started as alternative and later
we merged everything in ovirt-register project which is the generic
registration. I can send a patch to drop it soon.
Right.
So let's see what Dan replies and then we can possibly drop the
duplicate effort.
Thanks
fabian