Re: [Engine-devel] [Design for 3.2 RFE] Improving proxy selection algorithm for Power Management operations

From: "Itamar Heim" <iheim(a)redhat.com&gt; To: "Eli Mesika" <emesika(a)redhat.com&gt; Cc: "engine-devel" <engine-devel(a)ovirt.org&gt;, "Michael Pasternak" <mpastern(a)redhat.com&gt;, "Simon Grinberg" <sgrinber(a)redhat.com&gt;, "Dan Kenigsberg" <danken(a)redhat.com&gt; Sent: Friday, November 9, 2012 12:02:37 PM Subject: Re: [Engine-devel] [Design for 3.2 RFE] Improving proxy selection algorithm for Power Management operations On 11/09/2012 10:52 AM, Eli Mesika wrote: >> > >> > > FenceWrapper >> > >> >i understand danken suggested going this way, rather than than >> >another >> >instance of vdsm. >> >is vdsm only calling these scripts today and all logic is in >> >engine, >> >or >> >does vdsm has any logic in wrapping these scripts (not a blocker >> >to >> >doing FenceWrapper, just worth extracting that logic from vdsm to >> >such a >> >script, then using it in both. i hope answer is 'no logic'...) > vdsm has some logic that maps between the call passed to it from > engine and the actual parameters generated for the script. > AFAIK, this logic only "builds" the correct arguments for the > command according to the agent type > can we extract it to an external wrapper? I'd hate to fix bugs/changes twice for this.