On 03/27/2012 03:50 PM, Laszlo Hornyak wrote:
----- Original Message -----
From: "Yair Zaslavsky"<yzaslavs@redhat.com> To: "Laszlo Hornyak"<lhornyak@redhat.com> Cc: "engine-devel"<engine-devel@ovirt.org> Sent: Tuesday, March 27, 2012 3:41:04 PM Subject: Re: [Engine-devel] Feature: backend support for Advanced NFS Options
On 03/26/2012 03:01 PM, Laszlo Hornyak wrote:
Hi,
http://www.ovirt.org/wiki/Features/AdvancedNfsOptions#Changes_in_ovirt_engin...
Your feedback is welcome.
Few comments - a. Do we want to edit the options while storage domain is in maintenance mode?
I guess when it is in maintenance mode, the behavior should be that it should not be reconnected, but only the mount options stored. If the mount options are wrong... I think the domain will fallback when trying to activate.
b. Maybe calling this field "mount_options" (and not "nfs_options) (thinking about making it reusable for PosixFS feature).
Ah yes, last time I was editing this page the wiki crashed fopr a few hours and I forgot about it, but it was meant to be mount_options instead of nfs_options.
actually, why not make this generic as storage_domain_options, which could be used like custom properties for hooks later on?