Re: [ovirt-devel] Update on UI column sort infra issues

Hi guys, just a quick update on issues related to UI column sort infra. The client-side sorting fix [1] is now merged in master branch. The server-side sorting fix [2] is pending review. Also note that Lior merged a patch [3] which greatly simplifies code when making text-based columns *client-side* sortable, for example: TextColumnWithTooltip<SomeEntity> nameColumn = ... instead of this: // for text-based columns, need to provide separate Comparator // that (typically) uses LexoNumericComparator for comparison nameColumn.makeSortable(someEntityPropertyComparator); you can do this: // uses LexoNumericComparator to compare column's text values nameColumn.makeSortable();

-- [1] http://gerrit.ovirt.org/#/c/28392/ ... where items would disappear from grid when activating client-side column sorting [2] http://gerrit.ovirt.org/#/c/28557/ ... where triggering server-side sorting on a given column might corrupt the actual search query dispatched by the model [3] http://gerrit.ovirt.org/#/c/28670/ -- Regards, Vojtech _______________________________________________ Devel mailing list Devel(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/devel