Re: [Engine-devel] RFE: Netwrok Main Tab

From: "Simon Grinberg" <simon(a)redhat.com&gt; To: "Alona Kaplan" <alkaplan(a)redhat.com&gt; Cc: engine-devel(a)ovirt.org, "Muli Salem" <msalem(a)redhat.com&gt;, "Moti Asayag" <masayag(a)redhat.com&gt;, "Avi Tal" <atal(a)redhat.com&gt;, "Yaniv Kaul" <ykaul(a)redhat.com&gt; Sent: Wednesday, October 10, 2012 1:40:18 PM Subject: Re: [Engine-devel] RFE: Netwrok Main Tab ----- Original Message ----- > From: "Alona Kaplan" <alkaplan(a)redhat.com&gt; > To: "Simon Grinberg" <sgrinber(a)redhat.com&gt; > Cc: engine-devel(a)ovirt.org, "Muli Salem" <msalem(a)redhat.com&gt;, "Moti > Asayag" <masayag(a)redhat.com&gt;, "Avi Tal" > <atal(a)redhat.com&gt;, "Yaniv Kaul" <ykaul(a)redhat.com&gt; > Sent: Wednesday, October 10, 2012 10:39:50 AM > Subject: Re: [Engine-devel] RFE: Netwrok Main Tab > > I agree. > > Simon, what do you think? > > ----- Original Message ----- > > From: "Yaniv Kaul" <ykaul(a)redhat.com&gt; > > To: "Alona Kaplan" <alkaplan(a)redhat.com&gt; > > Cc: engine-devel(a)ovirt.org, "Muli Salem" <msalem(a)redhat.com&gt;, > > "Moti > > Asayag" <masayag(a)redhat.com&gt;, "Avi Tal" > > <atal(a)redhat.com&gt;, "Simon Grinberg" <sgrinber(a)redhat.com&gt; > > Sent: Tuesday, October 9, 2012 5:01:39 PM > > Subject: Re: [Engine-devel] RFE: Netwrok Main Tab > > > > On 10/09/2012 11:34 AM, Alona Kaplan wrote: > > > The wiki was updated with the final design. > > > http://wiki.ovirt.org/wiki/Feature/NetworkMainTab > > > > > > Thanks for the comments, > > > Alona. > > > > Is the general sub-tab providing any information not available in > > the > > grid already? > > If not, lets drop it. How complicated it will be to re-add it later? There is no added information in this tab since right now there is not much to report, everything can easily fit into the columns. But thinking forward you may have other values and properties. Just throwing some here not necessary for the near future so don't be alarmed, some may not/probably won't land in the general tab or the network main tab: - VM network / Storage / Migration / Management (*PS what is the current indication in this tab for management networks except for their names?) - Provider type - like external manager (Plug-in)/internal/etc (not sure it's a main tab item, but ... ) - Mutually exclusive? Redundancy? other properties. - Last modified by ___ (It's a property that I would have loved to see on all objects instead of searching the event log) - Modification date - Global SLA Policy (for hierarchical SLA) I think you got the drift And let's not forget 'Description' may not fully fit in it's column I think it's worth to have it now then to add it later when the need compels it. But not feeling too strongly one way or the other. > > And while it's also consistent to show the clusters as the second > > (or > > now, after the above suggestion first) sub-tab, it's not an > > interesting > > tab. I suggest the default when clicking on a network is to show > > the > > VMs > > tab (so while the order of the tabs is not changed, the default > > shown > > is). +1 > > Y. > > > > > > > > > > ----- Original Message ----- > > >> From: "Simon Grinberg" <simon(a)redhat.com&gt; > > >> To: "Alona Kaplan" <alkaplan(a)redhat.com&gt; > > >> Cc: engine-devel(a)ovirt.org > > >> Sent: Tuesday, October 2, 2012 7:36:44 PM > > >> Subject: Re: [Engine-devel] RFE: Netwrok Main Tab > > >> > > >> Trying to sum up some of the suggestions ('coincidently' > > >> dropping > > >> those which I think a bit too much for first implementation > > >> :)) > > >> and > > >> add some suggestions of my own > > >> > > >> 1. On the hosts subtab: > > >> 1.1 Have a radio button that will show either > > >> 1.1.1 All the hosts that this network is attached to > > >> 1.1.2 All the hosts where this network attached to the > > >> cluster > > >> but not to the host (Very important for non-required > > >> where > > >> the host status does not indicate something is > > >> missing) > > >> 1.2 Have a remove button for 1.1.1, ManageNetworks button > > >> for > > >> 1.1.2. Simple add will not do since you don't know where > > >> to > > >> add. > > >> > > >> 2. On the vms subtab > > >> 2.1 Have a radio button that will show either > > >> 2.1.1 All the vms that this network is attached to > > >> 2.1.2 All the vms where this network is not attached > > >> to > > >> 2.2 Have a 'remove' button for 2.1.1, Have 'add' button > > >> for > > >> 2.1.2 > > >> 2.3 Allow multiple selection for both actions of 2.2 > > >> 2.4 Add remove from all button. > > >> 2.5 I would not bother to show all the nics attached to > > >> the > > >> VM > > >> from the same network, it's too rare. Just make sure there > > >> is > > >> no > > >> exception if this does exist. So the columns should have > > >> 'nic' > > >> as > > >> the first and there should be only one VM per line. If > > >> there > > >> are > > >> more then one nic per VM then just indicate 'multiple' > > >> > > >> 3. Templates subtab - same as VM, drop the expansion of the > > >> NICs > > >> list. > > >> > > >> 4. Clusters subtab > > >> Allow assign to multiple clusters - same as the edit in > > >> the > > >> data > > >> center tab (Just use the same dialogue) > > >> > > >> 5. Main: You have enough space then why not add the MTU > > >> column? > > >> > > >> 6. Queries for the sub tabs: For each needs the reverse query > > >> as > > >> well > > >> (Probably more important when adding new network) > > >> > > >> > > >> Oops, I think I mostly added and dropped (almost) nothing :) > > >> > > >> Regards, > > >> Simon > > >> > > >> > > >> ----- Original Message ----- > > >>> From: "Avi Tal" <atal(a)redhat.com&gt; > > >>> To: "Yaniv Kaul" <ykaul(a)redhat.com&gt; > > >>> Cc: engine-devel(a)ovirt.org > > >>> Sent: Monday, September 24, 2012 10:13:52 AM > > >>> Subject: Re: [Engine-devel] RFE: Netwrok Main Tab > > >>> > > >>> > > >>> > > >>> ----- Original Message ----- > > >>>> From: "Yaniv Kaul" <ykaul(a)redhat.com&gt; > > >>>> To: "Moti Asayag" <masayag(a)redhat.com&gt; > > >>>> Cc: engine-devel(a)ovirt.org > > >>>> Sent: Sunday, September 23, 2012 6:16:47 PM > > >>>> Subject: Re: [Engine-devel] RFE: Netwrok Main Tab > > >>>> > > >>>> On 09/23/2012 06:12 PM, Moti Asayag wrote: > > >>>>> On 09/23/2012 05:01 PM, Yaniv Kaul wrote: > > >>>>>> On 09/23/2012 04:55 PM, Alona Kaplan wrote: > > >>>>>>> ----- Original Message ----- > > >>>>>>>> From: "Avi Tal" <atal(a)redhat.com&gt; > > >>>>>>>> To: "Alona Kaplan" <alkaplan(a)redhat.com&gt; > > >>>>>>>> Cc: engine-devel(a)ovirt.org > > >>>>>>>> Sent: Sunday, September 23, 2012 4:17:26 PM > > >>>>>>>> Subject: Re: [Engine-devel] RFE: Netwrok Main Tab > > >>>>>>>> > > >>>>>>>> > > >>>>>>>> > > >>>>>>>> ----- Original Message ----- > > >>>>>>>>> From: "Alona Kaplan" <alkaplan(a)redhat.com&gt; > > >>>>>>>>> To: "Avi Tal" <atal(a)redhat.com&gt; > > >>>>>>>>> Cc: engine-devel(a)ovirt.org > > >>>>>>>>> Sent: Sunday, September 23, 2012 1:31:32 PM > > >>>>>>>>> Subject: Re: [Engine-devel] RFE: Netwrok Main Tab > > >>>>>>>>> > > >>>>>>>>> 1. What actions do you suggest to add? > > >>>>>>>> Add, Edit and remove actions of each component. > > >>>>>>>> > > >>>>>>> Host: > > >>>>>>> Add- What will add action on Networks->Hosts sub tab do? > > >>>>>>> Choose > > >>>>>>> an > > >>>>>>> existing host and attach the network to one of its nics? > > >>>>>>> How will it work? after choosing the host you will open > > >>>>>>> setupNetworks > > >>>>>>> window and just enable dragging of the selected network > > >>>>>>> (in > > >>>>>>> the > > >>>>>>> main > > >>>>>>> tab) to a nic? I think it is too much. > > >>>>>>> > > >>>>>>> Edit- same as add. > > >>>>>>> > > >>>>>>> Remove- What is the meaning of Remove host in network's > > >>>>>>> context? > > >>>>>>> The > > >>>>>>> network will be detached from the host? I think it is > > >>>>>>> confusing. > > >>>>>>> > > >>>>>>> Vm/Template: > > >>>>>>> Add: What will it do? You will choose a vm and then add a > > >>>>>>> vnic > > >>>>>>> to > > >>>>>>> the > > >>>>>>> vm? Where will you see the vnic details? > > >>>>>>> Edit: Same as add. > > >>>>>>> Remove: You will remove all the vnics that use the > > >>>>>>> selected > > >>>>>>> network > > >>>>>>> from the vm? Or do you mean to add a remove per vnic? > > >>>>>> For all the above: yes. > > >>>>>> We can certainly work on the small details, but having a > > >>>>>> main > > >>>>>> tab > > >>>>>> with > > >>>>>> little to no action whatsoever is kinda disappointing. > > >>>>> IMO adding 'assign' action in the main tab might be handy > > >>>>> in > > >>>>> order > > >>>>> to > > >>>>> assign a single network in a single dialog to several > > >>>>> clusters. > > >>>>> > > >>>>> However It is not clear to me how Add/Edit for a VM in a > > >>>>> sub-tab > > >>>>> should > > >>>>> look like. The VM should have a list of interfaces > > >>>>> (represented > > >>>>> as > > >>>>> sub > > >>>>> collection/tree). > > >>>> I was thinking more of right-click on the network, selecting > > >>>> 'Add > > >>>> to > > >>>> VM' > > >>>> and then selecting single/mutliple VMs from a dialog with > > >>>> all > > >>>> the > > >>>> VMs > > >>>> (yes, filtered via search). > > >>>> Y. > > >>>> > > >>> +1 > > >>> > > >>>>> What will be the meaning of 'Add' in that context? Since > > >>>>> the > > >>>>> VM > > >>>>> already > > >>>>> have a vNIC attached to that network. If adding another > > >>>>> once, > > >>>>> it > > >>>>> should > > >>>>> be enabled on the record representing the VM itself which > > >>>>> will > > >>>>> confuse > > >>>>> the user. > > >>>>> Same goes for 'Edit' of a VM interface under a context of a > > >>>>> specific > > >>>>> network: in the current 'Edit VM Interface' you can change > > >>>>> the > > >>>>> network. > > >>>>> Should the same dialog be used here as well? > > >>>>> > > >>>>> The 'Remove' option is the clearer action on this context. > > >>>>> > > >>>>> > > >>>>>> (example of 'small details' - yes, when clicking remove > > >>>>>> for > > >>>>>> a > > >>>>>> VM/template - it will remove all vNICs that use that > > >>>>>> network > > >>>>>> from > > >>>>>> the > > >>>>>> VM. A VM with more than one vNIC on the same network is > > >>>>>> not > > >>>>>> the > > >>>>>> common > > >>>>>> case anyway, and if you want to remove just a single vNIC, > > >>>>>> go > > >>>>>> to > > >>>>>> the > > >>>>>> VM). I think we can also live with Add/Remove only, and > > >>>>>> 'defer' > > >>>>>> the edit > > >>>>>> actions to the respectable objects (host/vm/template) edit > > >>>>>> dialog > > >>>>>> boxes > > >>>>>> that originates from their own main tab. > > >>>>>> > > >>>>>> Y. > > >>>>>> > > >>>>>>>>> 2. I don't understand your suggestion. You mean add > > >>>>>>>>> SetupNetworks > > >>>>>>>>> to > > >>>>>>>>> the Networks main tab? > > >>>>>>>> No. > > >>>>>>>> Just Thinking of a nice display which will present > > >>>>>>>> logical > > >>>>>>>> network > > >>>>>>>> and his connected host/vm configuration instead of > > >>>>>>>> passing > > >>>>>>>> through > > >>>>>>>> dub-tabs > > >>>>>>>> I should give it a deeper thought. > > >>>>>>>> > > >>>>>>>> > > >>>>>>>>> ----- Original Message ----- > > >>>>>>>>>> From: "Avi Tal" <atal(a)redhat.com&gt; > > >>>>>>>>>> To: "Alona Kaplan" <alkaplan(a)redhat.com&gt; > > >>>>>>>>>> Cc: engine-devel(a)ovirt.org > > >>>>>>>>>> Sent: Thursday, September 20, 2012 6:58:05 PM > > >>>>>>>>>> Subject: Re: [Engine-devel] RFE: Netwrok Main Tab > > >>>>>>>>>> > > >>>>>>>>>> 1. Why not having Actions for Hosts, Vms and Templates > > >>>>>>>>>> ? > > >>>>>>>>>> I believe we should have those actions instead of > > >>>>>>>>>> making > > >>>>>>>>>> the > > >>>>>>>>>> user > > >>>>>>>>>> browse between 'network -> vms -> network (sub tab)' > > >>>>>>>>>> just > > >>>>>>>>>> in > > >>>>>>>>>> order > > >>>>>>>>>> to update VM's network. > > >>>>>>>>>> > > >>>>>>>>>> 2. Why having such a big window which most of the time > > >>>>>>>>>> will > > >>>>>>>>>> be > > >>>>>>>>>> empty? > > >>>>>>>>>> How many logical network would be existed in the > > >>>>>>>>>> system? > > >>>>>>>>>> My suggestion is to go for more graphical window > > >>>>>>>>>> which > > >>>>>>>>>> will > > >>>>>>>>>> present: > > >>>>>>>>>> A. logical networks > > >>>>>>>>>> B. Multiple networks with the host > > >>>>>>>>>> configurations > > >>>>>>>>>> at > > >>>>>>>>>> the > > >>>>>>>>>> same > > >>>>>>>>>> window: very important because most of the > > >>>>>>>>>> System > > >>>>>>>>>> admins > > >>>>>>>>>> would > > >>>>>>>>>> like to have a bigger picture of the entire > > >>>>>>>>>> network > > >>>>>>>>>> configuration > > >>>>>>>>>> > > >>>>>>>>>> > > >>>>>>>>>> > > >>>>>>>>>> > > >>>>>>>>>> > > >>>>>>>>>> ----- Original Message ----- > > >>>>>>>>>> From: "Alona Kaplan" <alkaplan(a)redhat.com&gt; > > >>>>>>>>>> To: engine-devel(a)ovirt.org > > >>>>>>>>>> Sent: Thursday, September 20, 2012 1:50:15 PM > > >>>>>>>>>> Subject: [Engine-devel] RFE: Netwrok Main Tab > > >>>>>>>>>> > > >>>>>>>>>> Hi all, > > >>>>>>>>>> > > >>>>>>>>>> Please review the wiki and add your comments. > > >>>>>>>>>> > > >>>>>>>>>> http://wiki.ovirt.org/wiki/Feature/NetworkMainTab > > >>>>>>>>>> > > >>>>>>>>>> > > >>>>>>>>>> > > >>>>>>>>>> RFE: > > >>>>>>>>>> https://bugzilla.redhat.com/858742 > > >>>>>>>>>> > > >>>>>>>>>> Thanks, > > >>>>>>>>>> Alona. > > >>>>>>>>>> _______________________________________________ > > >>>>>>>>>> Engine-devel mailing list > > >>>>>>>>>> Engine-devel(a)ovirt.org > > >>>>>>>>>> http://lists.ovirt.org/mailman/listinfo/engine-devel > > >>>>>>>>>> > > >>>>>>> _______________________________________________ > > >>>>>>> Engine-devel mailing list > > >>>>>>> Engine-devel(a)ovirt.org > > >>>>>>> http://lists.ovirt.org/mailman/listinfo/engine-devel > > >>>>>> _______________________________________________ > > >>>>>> Engine-devel mailing list > > >>>>>> Engine-devel(a)ovirt.org > > >>>>>> http://lists.ovirt.org/mailman/listinfo/engine-devel > > >>>> _______________________________________________ > > >>>> Engine-devel mailing list > > >>>> Engine-devel(a)ovirt.org > > >>>> http://lists.ovirt.org/mailman/listinfo/engine-devel > > >>>> > > >>> _______________________________________________ > > >>> Engine-devel mailing list > > >>> Engine-devel(a)ovirt.org > > >>> http://lists.ovirt.org/mailman/listinfo/engine-devel > > >>> > > > > >