----- Original Message ----- From: "Yair Zaslavsky" <yzaslavs@redhat.com> Sent: Tuesday, February 21, 2012 6:03:46 PM
On 02/21/2012 05:27 PM, Yaniv Kaul wrote:
On 02/21/2012 05:11 PM, Gilad Chaplik wrote:
Hello all,
The 'Import VM/Template More Than Once' feature description can be found under the following link:
http://www.ovirt.org/wiki/Features/ImportMoreThanOnce
Please review, and feel free to share your comments and thoughts.
Thanks, Gilad.
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
1. Missing high level (user level) summary. For example, what does it mean that a VM already exist in the setup? If I had a VM with 10GB disk, without an OS installed, then exported it, then installed an OS into it (so now the disk is a bit full, as opposed to the emptied exported one). Does it means that an identical entity already exist in the setup or not? (think of overwriting files). The design should (ALWAYS?) start with the user flow. 2. 'clone' doesn't strike me as a great parameter name in the API. Not in the UI either (but I don't have a better suggestion - yet). 3. What is the equivalent to 'suffix' in the API? Or do we expect to provide a name when we import? I'm not sure how the API works in the case of an existing VM, really. Only after we fetch via the API the fact
This reminds me that I was in a dilemma of suffix/prefix issue myself, in Clone VM from snapshot feature. I think this issue may be problematic , and for simplicity we should simply provide a new name.
* just to clarify: the suffix feature is a pure GUI feature, and it shouldn't involve the backend/api; the api should require a new name for every imported VM; the suffix text-box is just to allow the user to provide a new name for several imported VMs at once. * in case of "clone VM from snapshot", I think that providing a new name is enough (maybe provide a default name in the new name text-box, but again - it is GUI only), mainly because I don't think that we will allow cloning from several VMs/snapshots at once. [we might want to clone several VMs from the same snapshot, not sure how we will provide multiple names in such case]
it has an existing VM, we give it a new suffix? 4. Small typos (I'll fix them later directly in the wiki, except for the mockups, which I can't fix). Y.
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel