This is a multi-part message in MIME format. --------------0BFADDC735FF94D5E8A0931A Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 02/21/2017 02:44 PM, Yaniv Kaul wrote:
On Tue, Feb 21, 2017 at 1:06 PM Francesco Romani <fromani@redhat.com <mailto:fromani@redhat.com>> wrote:
Hello everyone,
in the last weeks I've been submitting PRs to collectd upstream, to bring the virt plugin up to date with Vdsm and oVirt needs.
Previously, the collectd virt plugin reported only a subset of metrics oVirt uses.
In current collectd master, the collectd virt plugin provides all the data Vdsm (thus Engine) needs. This means that it is now
possible for Vdsm or Engine to query collectd, not Vdsm/libvirt, and have the same data.
Do we wish to ship the unixsock collectd plugin? I'm not sure we do these days (4.1). We can do that later, of course, when we ship this. Y.
AFAIR the collectd unixsock plugin it's built and shipped by default by the collectd (even RPMs). It is the way the command line `collectdctl` too uses to talk with the daemon. Our client module is still work in progress. I'd be happy to just use a third party client module, the (semi-)official one is not shipped by default last time I checked; perhaps just file one RFE about that? -- Francesco Romani Red Hat Engineering Virtualization R & D IRC: fromani --------------0BFADDC735FF94D5E8A0931A Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit <html> <head> <meta content="text/html; charset=utf-8" http-equiv="Content-Type"> </head> <body bgcolor="#FFFFFF" text="#000000"> On 02/21/2017 02:44 PM, Yaniv Kaul wrote:<br> <blockquote cite="mid:CAJgorsZGMc7n6h9PGH5YK__1WoA1g7mVv1X1EjtNWphn4y+=hA@mail.gmail.com" type="cite"> <div dir="ltr"><br> <br> <div class="gmail_quote"> <div dir="ltr">On Tue, Feb 21, 2017 at 1:06 PM Francesco Romani <<a moz-do-not-send="true" href="mailto:fromani@redhat.com">fromani@redhat.com</a>> wrote:<br> </div> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello everyone,<br class="gmail_msg"> <br class="gmail_msg"> <br class="gmail_msg"> in the last weeks I've been submitting PRs to collectd upstream, to<br class="gmail_msg"> bring the virt plugin up to date with Vdsm and oVirt needs.<br class="gmail_msg"> <br class="gmail_msg"> Previously, the collectd virt plugin reported only a subset of metrics<br class="gmail_msg"> oVirt uses.<br class="gmail_msg"> <br class="gmail_msg"> In current collectd master, the collectd virt plugin provides all the<br class="gmail_msg"> data Vdsm (thus Engine) needs. This means that it is now<br class="gmail_msg"> <br class="gmail_msg"> possible for Vdsm or Engine to query collectd, not Vdsm/libvirt, and<br class="gmail_msg"> have the same data.<br class="gmail_msg"> </blockquote> <div><br> </div> <div>Do we wish to ship the unixsock collectd plugin? I'm not sure we do these days (4.1).</div> <div>We can do that later, of course, when we ship this.</div> <div>Y.</div> <br> </div> </div> </blockquote> <br> AFAIR the collectd unixsock plugin it's built and shipped by default by the collectd (even RPMs). It is the way the command line `collectdctl` too uses to talk with the daemon.<br> <br> Our client module is still work in progress.<br> <br> I'd be happy to just use a third party client module, the (semi-)official one is not shipped by default last time I checked; perhaps just file one RFE about that?<br> <br> <pre class="moz-signature" cols="72">-- Francesco Romani Red Hat Engineering Virtualization R & D IRC: fromani</pre> </body> </html> --------------0BFADDC735FF94D5E8A0931A--