[ovirt-devel] Re: OST gating: Merge aborted
On 19. 11. 2021, at 13:50, Milan Zamazal <mzamazal(a)redhat.com>
wrote:
Milan Zamazal <mzamazal(a)redhat.com> writes:
> Hi,
>
> https://gerrit.ovirt.org/c/vdsm/+/117543 reached "OST merge attempted"
that'
s why it says attempted, it cannot know if it will succeed
> but the merge hasn't happened. The trigger log says:
>
> + echo 'OST_MESSAGE=Patch is good to merge'
> + touch verified
> + exit 0
> [EnvInject] - Injecting environment variables from a build step.
> [EnvInject] - Injecting as environment variables the properties file path
'ost'
> [EnvInject] - Variables injected successfully.
> [ds-ost-gating-trigger3] $ /bin/sh -xe /tmp/jenkins3506416413422390774.sh
> + [[ -f approved ]]
> + [[ -f verified ]]
> + echo 'will submit'
> will submit
> + exit 0
> Build step 'Groovy Postbuild' changed build result to ABORTED
> Started calculate disk usage of build
> Finished Calculation of disk usage of build in 0 seconds
> Started calculate disk usage of workspace
> Finished Calculation of disk usage of workspace in 0 seconds
> Finished: ABORTED
>
> Any idea what's wrong?
Apparently missing CI+1 (due to the infamous DNS error that prevented
running tests after rebase). It would be nice if OST gating either
didn't attempt a merge at all in such a case, or failed with a
corresponding error message.
it's convoluted enough already, but feel free to implement that