Hi, I think it's nice to have some appreciation for helping (Beside a working Environment *g*), I don't have a problem with doing it automatically as my name also appears in the mailing lists and bugzilla. Till next time Christian -----Ursprüngliche Nachricht----- Von: Yedidyah Bar David [mailto:didi@redhat.com] Gesendet: Montag, 16. November 2015 11:12 An: Ondřej Svoboda <ondrej@svobodasoft.cz> Cc: devel <devel@ovirt.org>; Grundmann, Christian <Christian.Grundmann@fabasoft.com> Betreff: Re: [ovirt-devel] Reported-By - giving credit to our testers On Sun, Nov 15, 2015 at 9:35 PM, Ondřej Svoboda <ondrej@svobodasoft.cz> wrote:
On 13.11.2015 07:55, Sandro Bonazzola wrote:
On Thu, Nov 12, 2015 at 3:45 PM, Nir Soffer <nsoffer@redhat.com> wrote:
Hi all,
Our QE (and sometimes our users) are working hard testing and reporting bugs, but their effort is never mentioned in our code.
Looking at kernel git history, I found that they are using the Reported-By header for giving credit to the person reporting a bug. I suggest we adapt this header.
Here are some examples how we can use it:
- https://gerrit.ovirt.org/#/c/48483/3//COMMIT_MSG - https://github.com/oVirt/vdsm/commit/fb4c72af5e4c200409c74834111d44d9 2959ebbd - https://github.com/oVirt/vdsm/commit/f8127d88add881a4775e7030dde24331 25c7b598
infra: looking at above commit messages, can we get automatically added the following lines?
Reviewed-on: https://gerrit.ovirt.org/46540 on patch creation
Reviewed-by: Francesco Romani <fromani@redhat.com> on patch comment
+1 both to Nir's original idea and to Sandro's suggestions.
Now encountered [1] my first such case since this thread, and not sure I agree to automatically add people. Some people might not want that at all, some would prefer to have control over their name, some might prefer an email address different from the one used for posting or no email address at all. I usually ask people to open a bug or comment on an existing bug. Isn't that enough? Are git logs so much more important than bugzilla history? Another option I can think of is: Report-Url: http://lists.ovirt.org/pipermail/users/2015-November/035947.html Adding Christian, the reporter of [1]. Christian, feel free to ignore current thread, and/or voice up your opinion, and/or say if you want to appear as "Reported-By:" in the git commit message [2]. Thanks :-) [1] http://lists.ovirt.org/pipermail/users/2015-November/035947.html [2] https://gerrit.ovirt.org/48596 Best, -- Didi