Hello Martin, UI plugin API in 4.2 should be generally backwards compatible with 4.1. Comparing PluginManager.java between master and 4.1.8 - the exposePluginApi() function is exactly the same for now. However, we might do some API changes in the future, mainly due to 4.2 UI redesign. For example: - taking out the word "Tab" out of function names, since the UI concept of "main tab" is no more - as mentioned by Alex, support adding buttons inside kebab drop-down, as opposed to adding them directly to the toolbar (UX wise, important things should be outside kebab, less important things should go inside it) - support adding secondary level menu items when adding new "main tab" (this should become "add menu item" function) - support customizing the icon for primary menu items As for the visuals, as Greg wrote, UI plugins should generally follow the PatternFly styling to ensure consistent looks. WebAdmin has its own branding infra and UI plugins can use that. Just inspect the HTML source and see how WebAdmin requests PatternFly & branding related assets. Vojtech On Wed, Nov 29, 2017 at 1:22 AM, Greg Sheremeta <gshereme@redhat.com> wrote:
Hey,
We haven't changed the API, so everything should still work. For example, I just installed 4.1 versions of dashboard and support-plugin in master, and all's well [*]:
API:
api.addSubTab('Template', 'Red Hat Documentation', 'my-host-subtab-template', '<url snip>', {alignRight: true}); api.setTabAccessible('my-host-subtab-template', true);
[image: Inline image 1]
[*] however, note that "alignRight" is now ignored
And dashboard 4.1.8 installed in master engine:
[image: Inline image 2]
That said, we probably should have sent some announcement about making sure the plugins actually look good with the new theme. If some plugins are greenish, that will look bad.
To help with styling external things, we've started exposing more CSS via a new SASS brand module: https://github.com/oVirt/ovirt-engine/tree/master/frontend/brands/ ovirt-brand/src/main/sass <https://github.com/oVirt/ovirt-engine/tree/master/frontend/brands/ovirt-brand/src/main/sass> Also, we're heavily relying on base PatternFly styles, and plugins should do the same. For example, the new dialog styles are completely PatternFly [ http://www.patternfly.org/pattern-library/forms-and- controls/modal-overlay/] and we don't do anything extra on top of that.
Let us know if something doesn't work, or you need help styling something.
Greg
On Tue, Nov 28, 2017 at 6:25 PM, Martin Sivak <msivak@redhat.com> wrote:
Hi,
I just got a question from an ovirt-optimizer user about the support in 4.2. And I realized I haven't heard anything about how UI plugins should be updated to work with the new UI.
Is there anything special that needs to be done to make the plugin functional? Or will everything still work somehow?
Best regards
Martin Sivak _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
