--n/aVsWSeQ4JHkrmm Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 12/09, Oved Ourfali wrote:
=20 =20 ----- Original Message -----
From: "Sven Kieske" <s.kieske@mittwald.de> To: devel@ovirt.org Sent: Tuesday, December 9, 2014 3:21:43 PM Subject: Re: [ovirt-devel] Creating a new gerrit flag =20 =20 =20 On 09/12/14 13:47, Oved Ourfali wrote:
safe up to 95% or so. =20 You just made up that number. I don't really understand why you would want to downgrade your code quality by circumventing tests. =20 Maybe someone can elaborate on this a bit? =20 =20 It doesn't downgrade the code quality. It is just a way to ensure developers can both merge changes, and do it a= s safely as possible without relying on post-submit tools. The number is indeed invented... as I don't have real statistics, but it = comes to say that it would be safe most of the time. After the patch is merged, if CI will fail, it is the responsibility of t= he developer to check that out and fix that.
This thread was started to avoid getting to that point, as getting a failed patch inside the code means breaking all the other tests that run on top of it and that blocks all the development, not only that specific patch.
=20
-- Mit freundlichen Gr=FC=DFen / Regards =20 Sven Kieske =20 Systemadministrator Mittwald CM Service GmbH & Co. KG K=F6nigsberger Stra=DFe 6 32339 Espelkamp T: +49-5772-293-100 F: +49-5772-293-333 https://www.mittwald.de Gesch=E4ftsf=FChrer: Robert Meyer St.Nr.: 331/5721/1033, USt-IdNr.: DE814773217, HRA 6640, AG Bad Oeynhau= sen Komplement=E4rin: Robert Meyer Verwaltungs GmbH, HRB 13260, AG Bad Oeyn= hausen _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
--=20 David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Tel.: +420 532 294 605 Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605 --n/aVsWSeQ4JHkrmm Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUhvvOAAoJEEBxx+HSYmnDWPAIAJyDu1Mc1ZDBWnCm0pk06/KB GgOWGpJTsNb3mQIt9PeATg8zlr0HIko+iF+I4RiKVzbFVp0ZkTvrUn/vK102x4MI CAGTu9twyWScQWEhgc8RqOOJpP8wcpkk/Bf5vXPZunACVWyzouzx0Bge2nJkaUSg ik8a+bax9MnaT45R6NmUmC3P8/Eaj2ktavR6ZQLsX+Nq7C5SUKAgb1hShV+ZIu89 HEEgfExXslserA8Wd1G9V5qxDHzz5P7MFrU1DK6bFzzoE4uyOYwd5SUoBHYHySdh qJ0np5o9EEwmffpgxvnIuT2J00M7bIBJzoQ9AYm6/hj1sfeuzIYap/wgS3buK6g= =+hXp -----END PGP SIGNATURE----- --n/aVsWSeQ4JHkrmm--