--Apple-Mail=_E3F49A1E-B35C-4180-A492-AF33068E2F35 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8
On 12 Jan 2018, at 17:32, Yaniv Kaul <ykaul@redhat.com> wrote: =20 =20 =20 On Fri, Jan 12, 2018 at 1:05 PM, Michal Skrivanek = <michal.skrivanek@redhat.com <mailto:michal.skrivanek@redhat.com>> = wrote: =20 =20
On 12 Jan 2018, at 08:32, Tomas Jelinek <tjelinek@redhat.com = <mailto:tjelinek@redhat.com>> wrote: =20 =20 =20 On Fri, Jan 12, 2018 at 8:18 AM, Yaniv Kaul <ykaul@redhat.com = <mailto:ykaul@redhat.com>> wrote: =20 =20 On Fri, Jan 12, 2018 at 9:06 AM, Yaniv Kaul <ykaul@redhat.com = <mailto:ykaul@redhat.com>> wrote: See[1] - do we need to update Lago / Lago OST plugin? =20 Something like = https://github.com/lago-project/lago-ost-plugin/pull/31 = <https://github.com/lago-project/lago-ost-plugin/pull/31> perhaps (not = tested, don't have the HW). =20 yes, seems like that should do the trick. =20 sure, though, that list is also difficult to maintain e.g. IvyBridge is not an oVirt supported model, there=E2=80=99s no = =E2=80=9CSkylake=E2=80=9D model =20 Nadav, what=E2=80=99s the exact purpose of that list, and can it be = eliminated somehow? =20 It's to match, as possible, between the host CPU (which is passed to = L1) so it'll match oVirt=E2=80=99s.
getting it from "virsh capabilities" on the host would match it a bit = better. It would be enough to just make the L1 host report (via fake = caps hook if needed) the same model_X in getVdsCapabilities as the L0=20
It's not that difficult to maintain. We add new CPUs once-twice a = year=E2=80=A6?
Y. =20 =20 Thanks, michal =20 =20
=20 Y. =20 Error Message =20 Unsupported CPU model: Haswell-noTSX-IBRS. Supported models: = IvyBridge,Westmere,Skylake,Penryn,Haswell,Broadwell,Nehalem,Skylake-Client= ,Broadwell-noTSX,Conroe,SandyBridge,Haswell-noTSX Stacktrace =20 Traceback (most recent call last): File "/usr/lib64/python2.7/unittest/case.py", line 369, in run testMethod() File "/usr/lib/python2.7/site-packages/nose/case.py", line 197, in = runTest self.test(*self.arg) File "/usr/lib/python2.7/site-packages/ovirtlago/testlib.py", line = 129, in wrapped_test test() File "/usr/lib/python2.7/site-packages/ovirtlago/testlib.py", line = 59, in wrapper return func(get_test_prefix(), *args, **kwargs) File = "/home/jenkins/workspace/ovirt-system-tests_master_check-patch-el7-x86_64/= ovirt-system-tests/basic-suite-master/test-scenarios/002_bootstrap.py", =
add_cluster_4(prefix) File =
"/home/jenkins/workspace/ovirt-system-tests_master_check-patch-el7-x86_64/= ovirt-system-tests/basic-suite-master/test-scenarios/002_bootstrap.py", =
yes, not often line 277, in add_cluster line 305, in add_cluster_4
cpu_family =3D prefix.virt_env.get_ovirt_cpu_family() File "/usr/lib/python2.7/site-packages/ovirtlago/virt.py", line =
151, in get_ovirt_cpu_family
','.join(cpu_map[host.cpu_vendor].iterkeys()) RuntimeError: Unsupported CPU model: Haswell-noTSX-IBRS. Supported =
models: = IvyBridge,Westmere,Skylake,Penryn,Haswell,Broadwell,Nehalem,Skylake-Client= ,Broadwell-noTSX,Conroe,SandyBridge,Haswell-noTSX
=20 =20 Y. [1] = http://jenkins.ovirt.org/job/ovirt-system-tests_master_check-patch-el7-x86= _64/3498/testReport/junit/(root)/002_bootstrap/add_cluster/ = <http://jenkins.ovirt.org/job/ovirt-system-tests_master_check-patch-el7-x8= 6_64/3498/testReport/junit/(root)/002_bootstrap/add_cluster/> =20 _______________________________________________ Devel mailing list Devel@ovirt.org <mailto:Devel@ovirt.org> http://lists.ovirt.org/mailman/listinfo/devel = <http://lists.ovirt.org/mailman/listinfo/devel> =20 _______________________________________________ Devel mailing list Devel@ovirt.org <mailto:Devel@ovirt.org> http://lists.ovirt.org/mailman/listinfo/devel = <http://lists.ovirt.org/mailman/listinfo/devel>
--Apple-Mail=_E3F49A1E-B35C-4180-A492-AF33068E2F35 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 <html><head><meta http-equiv=3D"Content-Type" content=3D"text/html; = charset=3Dutf-8"></head><body style=3D"word-wrap: break-word; = -webkit-nbsp-mode: space; line-break: after-white-space;" class=3D""><br = class=3D""><div><br class=3D""><blockquote type=3D"cite" class=3D""><div = class=3D"">On 12 Jan 2018, at 17:32, Yaniv Kaul <<a = href=3D"mailto:ykaul@redhat.com" class=3D"">ykaul@redhat.com</a>> = wrote:</div><br class=3D"Apple-interchange-newline"><div class=3D""><br = class=3D"Apple-interchange-newline"><br style=3D"font-family: Helvetica; = font-size: 12px; font-style: normal; font-variant-caps: normal; = font-weight: normal; letter-spacing: normal; text-align: start; = text-indent: 0px; text-transform: none; white-space: normal; = word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=3D""><div = class=3D"gmail_quote" style=3D"font-family: Helvetica; font-size: 12px; = font-style: normal; font-variant-caps: normal; font-weight: normal; = letter-spacing: normal; text-align: start; text-indent: 0px; = text-transform: none; white-space: normal; word-spacing: 0px; = -webkit-text-stroke-width: 0px;">On Fri, Jan 12, 2018 at 1:05 PM, Michal = Skrivanek<span class=3D"Apple-converted-space"> </span><span = dir=3D"ltr" class=3D""><<a href=3D"mailto:michal.skrivanek@redhat.com" = target=3D"_blank" = class=3D"">michal.skrivanek@redhat.com</a>></span><span = class=3D"Apple-converted-space"> </span>wrote:<br = class=3D""><blockquote class=3D"gmail_quote" style=3D"margin: 0px 0px = 0px 0.8ex; border-left-width: 1px; border-left-style: solid; = border-left-color: rgb(204, 204, 204); padding-left: 1ex;"><div = style=3D"word-wrap: break-word; line-break: after-white-space;" = class=3D""><br class=3D""><div class=3D""><span class=3D""><br = class=3D""><blockquote type=3D"cite" class=3D""><div class=3D"">On 12 = Jan 2018, at 08:32, Tomas Jelinek <<a = href=3D"mailto:tjelinek@redhat.com" target=3D"_blank" = class=3D"">tjelinek@redhat.com</a>> wrote:</div><br = class=3D"m_5286394179726035691Apple-interchange-newline"><div = class=3D""><div dir=3D"ltr" class=3D""><br class=3D""><div = class=3D"gmail_extra"><br class=3D""><div class=3D"gmail_quote">On Fri, = Jan 12, 2018 at 8:18 AM, Yaniv Kaul<span = class=3D"Apple-converted-space"> </span><span dir=3D"ltr" = class=3D""><<a href=3D"mailto:ykaul@redhat.com" target=3D"_blank" = class=3D"">ykaul@redhat.com</a>></span><span = class=3D"Apple-converted-space"> </span>wrote:<br = class=3D""><blockquote class=3D"gmail_quote" style=3D"margin: 0px 0px = 0px 0.8ex; border-left-width: 1px; border-left-style: solid; = border-left-color: rgb(204, 204, 204); padding-left: 1ex;"><div = dir=3D"ltr" class=3D""><br class=3D""><div class=3D"gmail_extra"><br = class=3D""><div class=3D"gmail_quote"><span class=3D"">On Fri, Jan 12, = 2018 at 9:06 AM, Yaniv Kaul<span = class=3D"Apple-converted-space"> </span><span dir=3D"ltr" = class=3D""><<a href=3D"mailto:ykaul@redhat.com" target=3D"_blank" = class=3D"">ykaul@redhat.com</a>></span><span = class=3D"Apple-converted-space"> </span>wrote:<br = class=3D""><blockquote class=3D"gmail_quote" style=3D"margin: 0px 0px = 0px 0.8ex; border-left-width: 1px; border-left-style: solid; = border-left-color: rgb(204, 204, 204); padding-left: 1ex;"><div = dir=3D"ltr" class=3D"">See[1] - do we need to update Lago / Lago OST = plugin?</div></blockquote><div class=3D""><br class=3D""></div></span><div= class=3D"">Something like <a = href=3D"https://github.com/lago-project/lago-ost-plugin/pull/31" = target=3D"_blank" class=3D"">https://github.com/lago-p<wbr = class=3D"">roject/lago-ost-plugin/pull/31</a><span = class=3D"Apple-converted-space"> </span>perhaps (not tested, don't = have the HW).</div></div></div></div></blockquote><div class=3D""><br = class=3D""></div><div class=3D"">yes, seems like that should do the = trick.<br class=3D""></div></div></div></div></div></blockquote><div = class=3D""><br class=3D""></div></span>sure, though, that list is also = difficult to maintain</div><div class=3D"">e.g. IvyBridge is not an = oVirt supported model, there=E2=80=99s no =E2=80=9CSkylake=E2=80=9D = model</div><div class=3D""><br class=3D""></div><div class=3D"">Nadav, = what=E2=80=99s the exact purpose of that list, and can it be eliminated = somehow?</div></div></blockquote><div class=3D""><br class=3D""></div><div= class=3D"">It's to match, as possible, between the host CPU (which is = passed to L1) so it'll match = oVirt=E2=80=99s.</div></div></div></blockquote><div><br = class=3D""></div><div>getting it from "virsh capabilities" on the host = would match it a bit better. It would be enough to just make the L1 host = report (via fake caps hook if needed) the same model_X in = getVdsCapabilities as the L0 </div><br class=3D""><blockquote = type=3D"cite" class=3D""><div class=3D""><div class=3D"gmail_quote" = style=3D"font-family: Helvetica; font-size: 12px; font-style: normal; = font-variant-caps: normal; font-weight: normal; letter-spacing: normal; = text-align: start; text-indent: 0px; text-transform: none; white-space: = normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div = class=3D"">It's not that difficult to maintain. We add new CPUs = once-twice a year=E2=80=A6?</div></div></div></blockquote><div><br = class=3D""></div>yes, not often</div><div><br class=3D""><blockquote = type=3D"cite" class=3D""><div class=3D""><div class=3D"gmail_quote" = style=3D"font-family: Helvetica; font-size: 12px; font-style: normal; = font-variant-caps: normal; font-weight: normal; letter-spacing: normal; = text-align: start; text-indent: 0px; text-transform: none; white-space: = normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div = class=3D"">Y.</div><div class=3D""> </div><blockquote = class=3D"gmail_quote" style=3D"margin: 0px 0px 0px 0.8ex; = border-left-width: 1px; border-left-style: solid; border-left-color: = rgb(204, 204, 204); padding-left: 1ex;"><div style=3D"word-wrap: = break-word; line-break: after-white-space;" class=3D""><div class=3D""><br= class=3D""></div><div class=3D"">Thanks,</div><div = class=3D"">michal</div><div class=3D""><div class=3D"h5"><div = class=3D""><br class=3D""></div><div class=3D""><br class=3D""><blockquote= type=3D"cite" class=3D""><div class=3D""><div dir=3D"ltr" class=3D""><div= class=3D"gmail_extra"><div class=3D"gmail_quote"><div = class=3D""> </div><blockquote class=3D"gmail_quote" style=3D"margin: = 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; = border-left-color: rgb(204, 204, 204); padding-left: 1ex;"><div = dir=3D"ltr" class=3D""><div class=3D"gmail_extra"><div = class=3D"gmail_quote"><span class=3D"m_5286394179726035691HOEnZb"><font = color=3D"#888888" class=3D""><div class=3D"">Y.</div></font></span><span = class=3D""><div class=3D""> </div><blockquote class=3D"gmail_quote" = style=3D"margin: 0px 0px 0px 0.8ex; border-left-width: 1px; = border-left-style: solid; border-left-color: rgb(204, 204, 204); = padding-left: 1ex;"><div dir=3D"ltr" class=3D""><div class=3D""><h3 = style=3D"box-sizing: border-box; color: rgb(51, 51, 51); font-family: = Helvetica, Arial, sans-serif;" class=3D"">Error Message</h3><pre = style=3D"box-sizing: border-box; white-space: pre-wrap; word-wrap: = break-word; margin-top: 0px; margin-bottom: 0px; color: rgb(51, 51, 51); = font-size: 13px;" class=3D"">Unsupported CPU model: Haswell-noTSX-IBRS. = Supported models: IvyBridge,Westmere,Skylake,Pen<wbr = class=3D"">ryn,Haswell,Broadwell,Nehalem,<wbr = class=3D"">Skylake-Client,Broadwell-noTSX<wbr = class=3D"">,Conroe,SandyBridge,Haswell-<wbr class=3D"">noTSX</pre><h3 = style=3D"box-sizing: border-box; color: rgb(51, 51, 51); font-family: = Helvetica, Arial, sans-serif;" class=3D"">Stacktrace</h3><pre = style=3D"box-sizing: border-box; white-space: pre-wrap; word-wrap: = break-word; margin-top: 0px; margin-bottom: 0px; color: rgb(51, 51, 51); = font-size: 13px;" class=3D"">Traceback (most recent call last): File "/usr/lib64/python2.7/unittest<wbr class=3D"">/case.py", line = 369, in run testMethod() File "/usr/lib/python2.7/site-packa<wbr class=3D"">ges/nose/case.py", = line 197, in runTest self.test(*self.arg) File "/usr/lib/python2.7/site-packa<wbr = class=3D"">ges/ovirtlago/testlib.py", line 129, in wrapped_test test() File "/usr/lib/python2.7/site-packa<wbr = class=3D"">ges/ovirtlago/testlib.py", line 59, in wrapper return func(get_test_prefix(), *args, **kwargs) File "/home/jenkins/workspace/ovirt<wbr = class=3D"">-system-tests_master_check-pat<wbr = class=3D"">ch-el7-x86_64/ovirt-system-tes<wbr = class=3D"">ts/basic-suite-master/test-sce<wbr = class=3D"">narios/002_bootstrap.py", line 277, in add_cluster add_cluster_4(prefix) File "/home/jenkins/workspace/ovirt<wbr = class=3D"">-system-tests_master_check-pat<wbr = class=3D"">ch-el7-x86_64/ovirt-system-tes<wbr = class=3D"">ts/basic-suite-master/test-sce<wbr = class=3D"">narios/002_bootstrap.py", line 305, in add_cluster_4 cpu_family =3D prefix.virt_env.get_ovirt_cpu_<wbr class=3D"">family() File "/usr/lib/python2.7/site-packa<wbr = class=3D"">ges/ovirtlago/virt.py", line 151, in get_ovirt_cpu_family ','.join(cpu_map[host.cpu_vend<wbr class=3D"">or].iterkeys()) RuntimeError: Unsupported CPU model: Haswell-noTSX-IBRS. Supported = models: IvyBridge,Westmere,Skylake,Pen<wbr = class=3D"">ryn,Haswell,Broadwell,Nehalem,<wbr = class=3D"">Skylake-Client,Broadwell-noTSX<wbr = class=3D"">,Conroe,SandyBridge,Haswell-<wbr class=3D"">noTSX</pre><pre = style=3D"box-sizing: border-box; white-space: pre-wrap; word-wrap: = break-word; margin-top: 0px; margin-bottom: 0px; color: rgb(51, 51, 51); = font-size: 13px;" class=3D""><br class=3D""></pre><pre = style=3D"box-sizing: border-box; white-space: pre-wrap; word-wrap: = break-word; margin-top: 0px; margin-bottom: 0px; color: rgb(51, 51, 51); = font-size: 13px;" class=3D""><br class=3D""></pre></div><div = class=3D""><pre style=3D"box-sizing: border-box; white-space: pre-wrap; = word-wrap: break-word; margin-top: 0px; margin-bottom: 0px; color: = rgb(51, 51, 51); font-size: 13px;" class=3D"">Y.</pre><pre = style=3D"box-sizing: border-box; white-space: pre-wrap; word-wrap: = break-word; margin-top: 0px; margin-bottom: 0px; color: rgb(51, 51, 51); = font-size: 13px;" class=3D"">[1] <a = href=3D"http://jenkins.ovirt.org/job/ovirt-system-tests_master_check-patch= -el7-x86_64/3498/testReport/junit/(root)/002_bootstrap/add_cluster/" = target=3D"_blank" class=3D"">http://jenkins.ovirt.org/job/o<wbr = class=3D"">virt-system-tests_master_check<wbr = class=3D"">-patch-el7-x86_64/3498/testRep<wbr = class=3D"">ort/junit/(root)/002_bootstrap<wbr = class=3D"">/add_cluster/</a></pre></div></div></blockquote></span></div><b= r class=3D""></div></div><br class=3D"">______________________________<wbr= class=3D"">_________________<br class=3D"">Devel mailing list<br = class=3D""><a href=3D"mailto:Devel@ovirt.org" target=3D"_blank" = class=3D"">Devel@ovirt.org</a><br class=3D""><a = href=3D"http://lists.ovirt.org/mailman/listinfo/devel" rel=3D"noreferrer" = target=3D"_blank" class=3D"">http://lists.ovirt.org/mailman<wbr = class=3D"">/listinfo/devel</a><br class=3D""></blockquote></div><br = class=3D""></div></div>______________________________<wbr = class=3D"">_________________<br class=3D"">Devel mailing list<br = class=3D""><a href=3D"mailto:Devel@ovirt.org" target=3D"_blank" = class=3D"">Devel@ovirt.org</a><br class=3D""><a = href=3D"http://lists.ovirt.org/mailman/listinfo/devel" target=3D"_blank" = class=3D"">http://lists.ovirt.org/<wbr = class=3D"">mailman/listinfo/devel</a></div></blockquote></div></div></div>= </div></blockquote></div></div></blockquote></div><br = class=3D""></body></html>= --Apple-Mail=_E3F49A1E-B35C-4180-A492-AF33068E2F35--