On Thu, 28 Jul 2016 13:28:42 +0200 Tomáš Golembiovský <tgolembi@redhat.com> wrote:
On Thu, 21 Jul 2016 08:24:57 -0400 (EDT) Francesco Romani <fromani@redhat.com> wrote:
----- Original Message -----
From: "Nir Soffer" <nsoffer@redhat.com> To: "Tomáš Golembiovský" <tgolembi@redhat.com> Cc: "Francesco Romani" <fromani@redhat.com>, "devel" <devel@ovirt.org>, "Yaniv Bronheim" <ybronhei@redhat.com>, "Shahar Havivi" <shaharh@redhat.com> Sent: Thursday, July 21, 2016 2:17:19 PM Subject: Re: [ovirt-devel] execCmd() and storing stdout and stderr in log file
On Thu, Jul 21, 2016 at 1:51 PM, Tomáš Golembiovský <tgolembi@redhat.com> wrote:
On Thu, 21 Jul 2016 03:26:44 -0400 (EDT) Francesco Romani <fromani@redhat.com> wrote: [...]
I think is time to wrap up so Tomas can finish his work.
So, the options on the table are: 1. Build pipelines in python (Nir's approach above) - looks like the the fix is in cpopen 1.4.1, available
X. One more option that occured to me is: use Nir's approach but use subprocess.Popen directly.
Until we integrate with subprocess32, you should use compat.CPopen.
When subprocess32 is ready, the correct way would be compat.Popen, hiding the subprocess32 import on Python 2.7.
- since Yaniv said updated cpopen won't be available for 4.0
We don't need the update for 4.0, cpopen 1.4.1, available in 4.0 should be good enough.
I still see only 1.4 in repos. But if there will be 1.4.1 for 4.0 it is good enough.
So it's tagged as 1.4.1 but packaged as 1.4-1. Well you got me there. Anyway, I'm glad I have the package. -- Tomáš Golembiovský <tgolembi@redhat.com>