Re: [ovirt-devel] new internal stable modules + proposal

On 29/03/16 11:12 -0400, Francesco Romani wrote: Hi. I agree that some modules should be kept (and advertised) as stable. The name 'common' is more suited for such package as 'infra' is very ovirt specific and could hurt readability and navigation of the project. It does make sense to structure the project as follows: lib/vdsm/common lib/vdsm/virt/common lib/vdsm/storage/common lib/vdsm/network/common Taking extra care taken to avoid 'common junkyard' situation and making sure that the scope of common corresponds to it's package. List of modules that I consider public (mostly author/main contributor of these lately): lib/vdsm/cpuarch.py lib/vdsm/cpuinfo.py lib/vdsm/hostdev.py lib/vdsm/machinetype.py lib/vdsm/numa.py lib/vdsm/osinfo.py lib/vdsm/udevadm.py I agree about keeping global metadata in that way, except ideally using docstrings for better readability (e.g. interactive help()). To better reflect the needs for granular deprecation and based on our private discussion on this subject, I'd like to see at least @deprecated(target_removal_version) decorator. On top of that, we need properly documented public API and deprecation process.