
16 Dec
2012
16 Dec
'12
6:57 a.m.
On 12/14/2012 01:25 PM, Juan Hernandez wrote: > On 12/13/2012 03:55 PM, Roy Golan wrote: >> On 12/13/2012 04:49 PM, Vojtech Szocs wrote: >>>> this is making the contribution process more complex. lets think of a >>>> lighter way to get a developing setup. >>> I agree, I just wanted to have the local Engine configuration steps documented for reference.. If there's a better way to do it, I'm for it. >>> >>> Vojtech >> having LocalConfig look for "engine.conf.defaults" system property >> before fallback to System.getenv("ENGINE_DEFAULTS"); >> + concatenating -Dengine.conf.defaults=$HOME/.engine.conf.defaults >> to JAVA_OPTS on standalone.conf > How is the system property simpler than the environment variable? > > I agree that this makes the development process a bit more complex at > the moment, but I think that the way to make it simpler is not to > continue adding things to standalone.conf. I think that we should move > towards a development environment that is closer to the production > environment, not the other way around. till certain point. that's why we have an installation script for production and "make install" for a developer - alternatively, if(!) its easy and smooth we can run the engine-setup with an answer file or just a "dev" flag than we can call it from the -Psetup profile and make a unified process > Ideally the developer should be > able to do something like "make install" to have the engine deployed to > a directory structure similar to what he have in the production > environment. +1 and this is where the dev setup should end. > Then you should be able to go to the bin directory inside > that structure and start the engine (and the other tools) using the same > script that we use in production environments. If we achieve this goal > then we have a simple development environment setup and also we have all > developers testing almost the same thing that will go into the > production environments. again agree but only if its simple (minimum steps, don't have to follow a long and detailed wiki) and fast. > At the moment we don't have that, most times > you are testing something quite different (in terms of directory > structure, configuration, etc) to what will be installed in production > environments. I am working in that direction. > >>> >>> ----- Original Message ----- >>> From: "Roy Golan" <rgolan@redhat.com> >>> To: engine-devel@ovirt.org >>> Sent: Thursday, December 13, 2012 3:36:40 PM >>> Subject: Re: [Engine-devel] Error on starting webadmin >>> >>> On 12/13/2012 04:32 PM, Vojtech Szocs wrote: >>>> Hi, >>>> >>>> I've updated http://www.ovirt.org/Building_Engine_Draft - added section "Engine local configuration" (feel free to edit or modify as necessary) >>> this is making the contribution process more complex. lets think of a >>> lighter way to get a developing setup. >>> >>>> Vojtech >>>> >>>> >>>> ----- Original Message ----- >>>> From: "Vojtech Szocs" <vszocs@redhat.com> >>>> To: engine-devel@ovirt.org >>>> Sent: Thursday, December 13, 2012 2:49:39 PM >>>> Subject: Re: [Engine-devel] Error on starting webadmin >>>> >>>> Hi guys, >>>> >>>> as Moti mentioned, this issue is related to UI plugins patches that have been merged recently. >>>> >>>> However, the root cause of this issue is LocalConfig class (machine-specific Engine configuration) throwing exception in following cases: >>>> - cannot load default properties (ENGINE_DEFAULTS property if defined, otherwise /usr/share/ovirt-engine/conf/engine.conf.defaults) >>>> - cannot load custom properties (ENGINE_VARS property if defined, otherwise /etc/sysconfig/ovirt-engine) >>>> - requesting missing property value (LocalConfig.getProperty method) >>>> >>>> (Note that UI plugins use two Engine properties: ENGINE_USR and ENGINE_ETC.) >>>> >>>> As Juan suggests in his comment in http://gerrit.ovirt.org/#/c/10026/, we could include this in "building Engine" wiki. For example: >>>> - have ENGINE_DEFAULTS property point to OVIRT_HOME/backend/manager/conf/engine.conf.defaults (alternatively, users can copy this file to /usr/share/ovirt-engine/conf) >>>> - create custom Engine config file, e.g. ~/myengine.conf, and have ENGINE_VARS property point to this file >>>> >>>> Vojtech >>>> >>>> >>>> ----- Original Message ----- >>>> From: "Daniel Erez" <derez@redhat.com> >>>> To: "Moti Asayag" <masayag@redhat.com> >>>> Cc: engine-devel@ovirt.org >>>> Sent: Thursday, December 13, 2012 11:49:13 AM >>>> Subject: Re: [Engine-devel] Error on starting webadmin >>>> >>>> >>>> >>>> ----- Original Message ----- >>>>> From: "Moti Asayag" <masayag@redhat.com> >>>>> To: engine-devel@ovirt.org >>>>> Sent: Thursday, December 13, 2012 12:25:07 PM >>>>> Subject: [Engine-devel] Error on starting webadmin >>>>> >>>>> Hi, >>>>> >>>>> I get the following error when trying to connect to webadmin: >>>>> >>>>> 2012-12-13 11:57:06,689 ERROR >>>>> [org.apache.catalina.core.ContainerBase.[jboss.web].[default-host].[/webadmin].[WebAdminDynamicHosting]] >>>>> (http--0.0.0.0-8700-1) Servlet.service() for servlet >>>>> WebAdminDynamicHosting threw exception: >>>>> java.lang.IllegalArgumentException: The property "ENGINE_USR" >>>>> doesn't have a value. >>>>> >>>>> It caused by the PluginDataManager instantiation which requires >>>>> several variables to be defined. >>>>> >>>>> In order to by pass those errors do: >>>>> 1. create a file /usr/share/ovirt-engine/conf/engine.conf.defaults >>>>> 2. Add the following properties to the file: >>>>> ENGINE_USR=username >>>>> ENGINE_ETC=/etc/ovirt-engine >>>>> 3. restart Jboss >>>> You can use the 'engine.conf.defaults' that resides at 'backend/manager/conf'. >>>> >>>>> Regards, >>>>> Moti