Regarding that comment question, I am not talking about the comment we put while commit. But the comment for the bug at github issue section. For ex: https://github.com/oVirt/ovirt-site/issues/994 On Thu, Jun 1, 2017 at 12:02 AM, shubham dubey <sdubey504@gmail.com> wrote:
Thanks for help. One more thing I want to know is that, is it necessary to fork the ovirt-site first into your repository to send a pr.
On Wed, May 31, 2017 at 11:57 PM, Dan Kenigsberg <danken@redhat.com> wrote:
On Wed, May 31, 2017 at 9:20 PM, shubham dubey <sdubey504@gmail.com> wrote:
Hi, I want to fix some issues in ovirt site. Since I never did a pull request before, hence want to know few things. 1)can I fix multiple bug and send a single pr for them.
You can send one pull request, but each of its commits should fix a single issue. Then again, if the fixes are unrelated to each other, you'd better use different PRs.
2) when I fix a issue did I need to write something in the comment of the bug (like 'fixed' or 'patch send').
Actually, you should usually write something longer, such as "fix a broken link" or "add a clearer paragraph, as the former text was confusing" - anything that can explain to your reviewer the motivation for your commit.
thanks in advance and I will appreciate for extra related info:)
Shubham
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel