On Fri, Oct 4, 2019 at 9:56 PM Nir Soffer <nsoffer(a)redhat.com> wrote:
> On Fri, Oct 4, 2019 at 9:44 PM Nir Soffer <nsoffer(a)redhat.com> wrote:
>
>> On Fri, Oct 4, 2019 at 9:32 PM Nir Soffer <nsoffer(a)redhat.com> wrote:
>>
>>> On Fri, Oct 4, 2019 at 8:50 PM Nir Soffer <nsoffer(a)redhat.com> wrote:
>>>
>>>> Looks like wrong coverage report:
>>>>
>>>> ---------- coverage: platform linux2, python 2.7.16-final-0 ----------
>>>> Coverage HTML written to dir htmlcov-network-py27
>>>> FAIL Required test coverage of 38% not reached. Total coverage: 0.00%
>>>>
>>>>
https://travis-ci.org/oVirt/vdsm/builds/593661358
>>>>
>>>
>>> Also on jenkins:
>>>
https://jenkins.ovirt.org/job/vdsm_standard-check-patch/12604/
>>>
<
https://jenkins.ovirt.org/job/vdsm_standard-check-patch/12604//artifact/c...
>>>
https://jenkins.ovirt.org/job/vdsm_standard-check-patch/12603/
>>>
>>
>> ----------- coverage: platform linux, python 3.7.4-final-0 -----------
>>
>> Coverage HTML written to dir htmlcov-network-py37
>>
>> FAIL Required test coverage of 42% not reached. Total coverage: 0.00%
>>
>> Looking at exported artifacts, we don't write now the coverage reports:
>>
>>
https://jenkins.ovirt.org/job/vdsm_standard-check-patch/12604/artifact/ch...
>>
>> This will fail any vdsm patch.
>>
>>
> Looks like this issue, filed 1 hour ago:
>
https://github.com/pytest-dev/pytest-cov/issues/348
>
The latest pytest-cov is broken.
I fixed the plugin version [1] and it seems to work now.
[1]
https://gerrit.ovirt.org/#/c/103870/