On 19 Sep 2017, at 14:08, Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com> wrote:
On 18.09.2017 17:52, Juan Hernández wrote:
On 09/18/2017 05:31 PM, Viktor Mihajlovski wrote:
Hi,
I have submitted a topic branch containing the changes necessary to enable support for the s390 arch in VDSM and would appreciate your feedback, not only for the code, but also on the procedure:
1. I've submitted the patches as draft, following the suggestions on the homepage. Not sure whether this is really required.
2. The individual commits are actually tiny, let me know whether this is OK, or you prefer a single commit.
3. Topic branch here: https://gerrit.ovirt.org/#/q/topic:s390-base
Note that draft changes are generally OK, but they have the inconvenient that they are invisible for people that isn't explicitly added as reviewers. So you will need to either promote them to regular patches, maybe adding a [WIP] prefix to the subject, or else explicitly add reviewers, otherwise nobody will see them.
Thanks for the clarification, I have done as you suggested. Looking forward for comments.
Hi Viktor, thank you for the contribution! It looks good so far, some of the patches are already in a good shape, feel free to remove the WIP prefix. Size of the patches is also quite matching the typical scope of each patch, at least for vdsm. Do you intend to work on ovirt-engine component as well? If yes then it would be great if you share the areas which you expect will need to change, or perhaps some other higher level overview of what kind of changes in general are required in oVirt to have a complete s390 support Let me know if I can help with that in any way, if there is any information you may need about existing design Thanks, michal
--
Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski
IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Martina Köderitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel