Re: [ovirt-devel] Gluster Volume Snapshots - Feature review

Thanks Juan for the comments. I would update the wiki accordingly and send for confirmation. Regards Shubhendu Sent from Samsung Mobile -------- Original message -------- From: Juan Hernández <jhernand(a)redhat.com&gt; Date: 09/12/2014 18:51 (GMT+05:30) To: Shubhendu Tripathi <shtripat@redhat.com&gt;,devel(a)ovirt.org,Michael Pasternak <mpastern(a)redhat.com&gt; Subject: Re: [ovirt-devel] Gluster Volume Snapshots - Feature review On 12/04/2014 07:11 PM, Shubhendu Tripathi wrote: > Hi Juan/Michael, > > This is a gentle reminder for the review of the REST api design for the > below feature. > We would be starting the REST development for the same soon (probably by > Dec 2014 end). > > If there are specific comments, please pass it on. If no comments we > would go ahead with the current design and implement accordingly. > > Request your time for this. > > Thanks and Regards, > Shubhendu > > On 11/10/2014 12:22 PM, Shubhendu Tripathi wrote: >> Hi All, >> >> Please help us to review the design of Gluster Volume Snapshots in oVirt, >> >> Here are two design on wiki page >> >> General Feature Design >> http://www.ovirt.org/Features/GlusterVolumeSnapshots >> >> Detailed Design >> http://www.ovirt.org/Features/Design/GlusterVolumeSnapshots >> >> We target it in ovirt 3.6 release. >> >> Marked Juan/Michael specifically for REST review. >> >> Best Regards, >> Shubhendu Tripathi My comments about the RESTAPI: 1. You can't use the "snapshot" and "snapshots" XML elements, as those are already in use for disk snapshots, and we don't have name space support in the RESTAPI. You will have to use something different, for example "gluster_volume_snapshots" and "gluster_volume_snapshot". 2. When adding a volume snapshot the name of the volume shouldn't be a parameter, as that is implicit. Only the name and description of the snapshot should be provided. 3. The operation to delete a snapshot should be performed on the snapshot resource, not on the collection: DELETE /clusters/{cluster:id}/glustervolumes/{volume:id}/snapshots/{snapshot:id} Ideally this operation shouldn't receive any parameters (thus no body). If it does require parameters then they should be contained inside an "action" element. 4. The operation to update the snapshot configuration should be the PUT operation of the volume, not a new "snapshotconfig" sub-resource, as these kind of sub-resources aren't well supported by the SDKs and the CLI.