Re: [ovirt-devel] Findbugs on master patches
--svZFHVx8/dhPCe52
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On 08/12, Yevgeny Zaspitsky wrote:
My bad, sorry. The findbugs job runs indeed.
=20
However look at that patch https://gerrit.ovirt.org/#/c/44604/ .
Patch set 1 got Continuous-Integration+1 from Jenkins after running unit
tests and then, much later,
That much later is after merge, the findbugs ran once the patch was merged.=
You
should understand that each event triggers a tests run, and for each tests =
run
you get only one review. In this case the tests that check the code when you
send the patch passed, but the ones that check the code after it's merged
failed.
Jenkins changed its mind and gave -1 after
findbugs job has finished.
IMHO that's is a misleading behavior.
=20
Regards,
Yevgeny
=20
On Wed, Aug 12, 2015 at 12:12 PM, Sandro Bonazzola <sbonazzo(a)redhat.com>
wrote:
=20
>
>
> On Tue, Aug 11, 2015 at 6:13 PM, Yevgeny Zaspitsky <yzaspits(a)redhat.com>
> wrote:
>
>> Hi All,
>>
>> Seems like recently Jenkins has stopped running findbugs check on the
>> patches before they get merged into master. Although that could save s=
ome
>> Jenkins resources and make the its reaction faster, that
makes the
>> integration (with master) check less effective.
>>
>> Was that done on purpose? Can that be restored for master patches?
>>
>>
> AFAIK findbugs is still up and running:
> http://jenkins.ovirt.org/search/?q=3Dfind-bugs
> Have you any specific patch as example?
>
>
>
>
>> Regards,
>> Yevgeny
>>
>> _______________________________________________
>> Devel mailing list
>> Devel(a)ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/devel
>>
>
>
>
> --
> Sandro Bonazzola
> Better technology. Faster innovation. Powered by community collaboratio=
n.
> See how it works at redhat.com
>
_______________________________________________
Infra mailing list
Infra(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra
--=20
David Caro
Red Hat S.L.
Continuous Integration Engineer - EMEA ENG Virtualization R&D
Tel.: +420 532 294 605
Email: dcaro(a)redhat.com
Web: www.redhat.com
RHT Global #: 82-62605
--svZFHVx8/dhPCe52
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQEcBAEBAgAGBQJVyz8qAAoJEEBxx+HSYmnD4HEH+gP4llJCBrn49KkKD72mmUpT
4v8BOCfbXjr1l+XKmGUQvqRHkHhDK62MnLbdwwh3ZN3O2Yo+aa/ZBd6ew8znlTfY
5mxPaOxmT6vFX9mnpQJyWuLwzLxPgNaxs4BtKTI5k46sNlmdr/p9wBu38aAejmTq
cjzGCz8ubK7SkoaRWCOwRDhI81KbIWYLtfNAYkZ1UfWqHbJGxBVuEOB8AmOr8c9x
ELhj+R7ochFi9t2G5aEvZT1D/3TGgcUhFxCA6zuvcDXZnearySrF+TrPMl66mRgP
VrpZ3FSPkUA0mkBODqKpcnkzLkWfrgwLxw91pS+Bp/ayMA+BtVNPKgaF17N7Ovs=
=ULdu
-----END PGP SIGNATURE-----
--svZFHVx8/dhPCe52--
Attachments:
- attachment.bin (multipart/signed — 2.8 KB)