On Thu, Mar 29, 2018 at 7:17 PM Dan Kenigsberg <danken@redhat.com> wrote:
On Wed, Mar 28, 2018 at 8:08 PM, Nir Soffer <nsoffer@redhat.com> wrote:
On Wed, Mar 28, 2018 at 10:15 AM Dan Kenigsberg <danken@redhat.com> wrote:
I suppose this test should be reworked, or at least, have its constants tweaked.
FAIL: test_slow_handler_sync (common.logutils_test.TestThreadedHandler) ---------------------------------------------------------------------- Traceback (most recent call last): File
"/home/jenkins/workspace/vdsm_master_check-patch-fc27-x86_64/vdsm/tests/common/logutils_test.py",
line 319, in test_slow_handler_sync self.assertGreater(max(workers_time), 0.9) AssertionError: 0.8714249134063721 not greater than 0.9
I tried to fix this last week, but for some reason the fix does not help on the CI.
I think we can remove this test, it is reproducing the issues with the standard logging code, and does not test the new code.
Thanks, akced.