Re: [Engine-devel] Small suggestions for engine-log-collector

From: "Sandro Bonazzola" <sbonazzo(a)redhat.com&gt; To: "Vojtech Szocs" <vszocs(a)redhat.com&gt; Cc: "Keith Robertson" <kroberts(a)redhat.com&gt;, "engine-devel" <engine-devel(a)ovirt.org&gt;, "Einav Cohen" <ecohen(a)redhat.com&gt; Sent: Monday, March 17, 2014 8:14:43 AM Subject: Re: Small suggestions for engine-log-collector Il 14/03/2014 17:58, Vojtech Szocs ha scritto: > > > ----- Original Message ----- >> From: "Sandro Bonazzola" <sbonazzo(a)redhat.com&gt; >> To: "Keith Robertson" <kroberts(a)redhat.com&gt;, "Vojtech Szocs" >> <vszocs(a)redhat.com&gt; >> Cc: "engine-devel" <engine-devel(a)ovirt.org&gt;, "Einav Cohen" >> <ecohen(a)redhat.com&gt; >> Sent: Thursday, March 13, 2014 1:27:46 PM >> Subject: Re: Small suggestions for engine-log-collector >> >> Il 11/03/2014 19:13, Keith Robertson ha scritto: >>> >>> >>> ----- Original Message ----- >>>> From: "Vojtech Szocs" <vszocs(a)redhat.com&gt; To: "engine-devel" >>>> <engine-devel(a)ovirt.org&gt; Cc: "Keith Robertson" <kroberts(a)redhat.com&gt;, >>>> "Einav Cohen" >>>> <ecohen(a)redhat.com&gt; Sent: Tuesday, March 11, 2014 1:57:11 PM Subject: >>>> Small suggestions for engine-log-collector >>>> >>>> Hi guys, >>>> >>>> based on my testing during last week's oVirt 3.4 RC test day [1], I have >>>> a >>>> couple of small suggestions for engine-log-collector: >>>> >>>> 1, in /etc/ovirt-engine/logcollector.conf - I think there's typo: >>>> >>>> #key-file=/etc/pki/engine/keys/engine_id_rsa >>>> >>>> should be: >>>> >>>> #key-file=/etc/pki/ovirt-engine/keys/engine_id_rsa >>>> >>> >>> ACK >> >> merged. >> >> >>> >>> >>>> 2, to force password-based ssh auth, one has to do this: >>>> >>> >>> In the normal scenario, the the ovirt user's public key should be >>> installed >>> into each hypervisor. Unless something has changed as a part of the >>> hypervisor registration process this should be something that we can >>> depend >>> upon. >>> >>> Clearly, there are edge cases where you need to collect logs from a >>> hypervisor that isn't properly registered with the RHEV-M. Was this your >>> situation and how common do you think this scenario is? >>> >>>> engine-log-collector -k "" >>>> >>> >>> Yes, you are nulling out the default value which causes the LC to prompt >>> you for a PW. Perhaps we should document this as opposed to supplying a >>> specific option? Sandro? >> >> yes, maybe a better explanation in man page. Vojtech have you opened a bz >> about that? > > No, first I wanted to hear your opinions :) I didn't open BZ for this yet. > > I think a better explanation in --help text is sufficient. (small thing) > > Should I open BZ for this? yes please, I think both --help and man page should be aligned.

> >> Thanks for the report and for the patch you submitted! >> >>> >>>> because running this: >>>> >>>> engine-log-collector -k >>>> >>>> returns error message: >>>> >>>> error: -k option requires an argument >>>> >>>> however, help for -k option mentions *supplying* the argument: >>>> >>>> If a identity file is not supplied the program will prompt for a >>>> password. >>>> >>>> so either the help text should mention empty string, or -k option should >>>> allow missing argument (this was my initial understanding according to >>>> help text) >>>> >>>> Since these are just small things, I'm wondering if I should create RFE >>>> or >>>> if Keith/others can say if they are relevant. >>>> >>>> Thanks, Vojtech >>>> >>>> [1] http://etherpad.ovirt.org/p/3.4-testday-3 >>>> >> >> >> -- >> Sandro Bonazzola >> Better technology. Faster innovation. Powered by community collaboration. >> See how it works at redhat.com >> -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com