Hi all Please note that there is still a problem on engine-setup I have already a fixing draft [1] Meanwhile, until this is verified and merged please do before engine-setup from dbscripts/upgrade dir psql -U engine -f 04_00_0210_add_vds_group_view.sql <db> Thanks and sorry for that, this will be fixed ASAP and reported in this thread. Eli [1] https://gerrit.ovirt.org/#/c/52454/ ----- Original Message -----
From: "Idan Shaby" <ishaby@redhat.com> To: "Eli Mesika" <emesika@redhat.com> Sent: Tuesday, January 19, 2016 10:10:17 AM Subject: Re: [ovirt-devel] No more "vds group" in master code , instead please use "cluster"
Hi Eli,
I've fetched and rebased master, and got this error while running engine-setup:
[ INFO ] Stage: Setup validation [WARNING] Cannot validate host name settings, reason: resolved host does not match any of the local addresses [ ERROR ] Failed to execute stage 'Setup validation': relation "vds_groups" does not exist LINE 2: SELECT compatibility_version FROM vds_groups... ^ [ INFO ] Stage: Clean up Log file is located at /home/ishaby/ovirt-engine/var/log/ovirt-engine/setup/ovirt-engine-setup-20160119100829-tebscp.log [ INFO ] Generating answer file '/home/ishaby/ovirt-engine/var/lib/ovirt-engine/setup/answers/20160119100830-setup.conf' [ INFO ] Stage: Pre-termination [ INFO ] Stage: Termination [ ERROR ] Execution of setup failed
Any idea?
Regards, Idan
On Sun, Jan 17, 2016 at 4:50 PM, Eli Mesika <emesika@redhat.com> wrote:
From: "Eli Mesika" <emesika@redhat.com> To: "Jakub Niedermertl" <jniederm@redhat.com> Cc: "devel" <devel@ovirt.org> Sent: Sunday, January 17, 2016 1:32:27 PM Subject: Re: [ovirt-devel] No more "vds group" in master code , instead
----- Original Message ----- please use "cluster"
----- Original Message -----
From: "Jakub Niedermertl" <jniederm@redhat.com> To: "Eli Mesika" <emesika@redhat.com> Cc: "devel" <devel@ovirt.org> Sent: Thursday, January 14, 2016 7:48:12 PM Subject: Re: [ovirt-devel] No more "vds group" in master code ,
instead
please use "cluster"
Hi Eli,
thank you, it helped. Now `engine-setup` works fine. However engine itself reports following in a few seconds after start:
ERROR: relation "clusters_storage_domain" does not exist
Relevant part of engine log: http://pastebin.test.redhat.com/340672 Tested on current master (commit 8561bb69560686d0) and clean db.
You are right, sorry for that ... This patch fixes that issue https://gerrit.ovirt.org/#/c/51929
Patch merged please re-base on master and try again
----- Original Message -----
From: "Eli Mesika" <emesika@redhat.com> To: "Jakub Niedermertl" <jniederm@redhat.com> Cc: "devel" <devel@ovirt.org> Sent: Thursday, January 14, 2016 1:10:42 AM Subject: Re: [ovirt-devel] No more "vds group" in master code ,
instead
please use "cluster"
----- Original Message -----
From: "Jakub Niedermertl" <jniederm@redhat.com> To: "Eli Mesika" <emesika@redhat.com> Cc: "devel" <devel@ovirt.org> Sent: Wednesday, January 13, 2016 9:18:57 PM Subject: Re: [ovirt-devel] No more "vds group" in master code , instead please use "cluster"
Hi Eli,
are db migration scripts supposed to handle this change? My `engine-setup` failed with following message in log:
Hi Jakub
Please re-base on latest master, there was an issue with that and it was solved in https://gerrit.ovirt.org/#/c/51784/
""" 2016-01-13 20:02:57 DEBUG otopi.ovirt_**FILTERED**_setup.**FILTERED**_common.database database.execute:172 Database: 'None', Statement: ' SELECT compatibility_version FROM cluster;; ', args: {} 2016-01-13 20:02:57 DEBUG otopi.ovirt_**FILTERED**_setup.**FILTERED**_common.database database.execute:177 Creating own connection 2016-01-13 20:02:57 DEBUG otopi.context context._executeMethod:156 method exception Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/otopi/context.py", line
146,
in _executeMethod method['method']() File
"/home/jakub/target/share/ovirt-**FILTERED**/setup/bin/../plugins/ovirt-**FILTERED**-setup/ovirt-**FILTERED**/db/schema.py",
line 218, in _validation self._checkSupportedVersionsPresent() File
"/home/jakub/target/share/ovirt-**FILTERED**/setup/bin/../plugins/ovirt-**FILTERED**-setup/ovirt-**FILTERED**/db/schema.py",
line 180, in _checkSupportedVersionsPresent transaction=False, File
"/home/jakub/target/share/ovirt-**FILTERED**/setup/ovirt_**FILTERED**_setup/**FILTERED**_common/database.py",
line 196, in execute args, ProgrammingError: relation "cluster" does not exist LINE 2: SELECT compatibility_version FROM cluster;; ^
2016-01-13 20:02:57 ERROR otopi.context context._executeMethod:165 Failed to execute stage 'Setup validation': relation "cluster" does not exist LINE 2: SELECT compatibility_version FROM cluster;; ^ """
Thank you for answer.
Best regards Jakub
----- Original Message ----- > From: "Eli Mesika" <emesika@redhat.com> > To: "devel" <devel@ovirt.org> > Sent: Wednesday, January 13, 2016 12:00:50 AM > Subject: [ovirt-devel] No more "vds group" in master code , instead > please > use "cluster" > > Hi > > I have merged today this patch[1] to master. > > The code from historical reasons uses both "vds group" and "cluster" > for > a > cluster entity. > This makes the code not-clear, non-readable and hard for beginners > (to > find > for example SPs that handle clusters , or all code related to a > cluster > operation) > This also makes our logging and error messages using sometimes "vds > group" > and sometimes "cluster" to relate to the same entity. > Worse than that, new code written sometimes introduce a mix of both > terms. > > Patch[1] renames "vds group" to cluster all over the code. > This renaming covers all engine code including > Class names > Variables > Comments > Logging > Error messages > Database tables,views, columns and SPs including all kinds of keys > and > constrains > > Please do not use from now on the term "vds group" (all its variants > (VdsGroup, vdsGroup, vds_group etc.) > Instead , cluster and all its variants should be used > > If you have some written code that is not merged yet, you will > probably > have > a little work on rebase on top this patch, as far as I know those > should > be > trivial patches and if you have any question, please ask. > > Possible affects on other products are minor and were communicated to > the > relevant product people. > > [1] https://gerrit.ovirt.org/#/c/51109/ > > Thanks > Eli Mesika > > _______________________________________________ > Devel mailing list > Devel@ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel >
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel