----- Original Message -----
From: "Sven Kieske" <s.kieske@mittwald.de> To: devel@ovirt.org Sent: Wednesday, September 17, 2014 12:01:50 PM Subject: Re: [ovirt-devel] Stable branch gerrit hook and Related-To: bug
Why should an incomplete, thus non working feature get merged? Do you also merge incomplete bugfixes?
One commit should contain one feature or one bugfix, imho? I know this can be difficult sometimes, but still, at least in the master branch this rule should get enforced, maybe create a staging branch for incomplete features?
On 16/09/14 14:53, Martin Sivak wrote:
it would mean that feature cannot be merged before it is completed.
If you look again at Martin's mail, he wrote:
That is not a bad idea, but there is one use case you do not consider.. it would mean that feature cannot be merged before it is completed. I like my patches to be merged as soon as possible. Of course if the patches leave the tree in working state.
And I agree with him. There is no harm in merging to master branch changes that do not harm it, even make it better, just because they do not completely fix an existing bugzilla bug. Actually I think the opposite is true - a large bug that requires a large and complex change is usually better split to smaller changes that are easier to review/verify/etc. -- Didi