[ovirt-devel] Re: Support OVN in rename (was: Change in ovirt-system-tests[master]: basic-suite: Run rename right after engine-setup)

On Mon, Jun 22, 2020 at 11:07 AM Code Review <gerrit(a)ovirt.org&gt; wrote: > > From Jenkins CI <jenkins(a)ovirt.org&gt;: > > Jenkins CI has posted comments on this change. > > Change subject: basic-suite: Run rename right after engine-setup > ...................................................................... > > > Patch Set 3: > > Build Failed > > https://jenkins.ovirt.org/job/ovirt-system-tests_standard-check-patch/9863/ : FAILURE This failed with: https://jenkins.ovirt.org/job/ovirt-system-tests_standard-check-patch/986... prefix = <ovirtlago.prefix.OvirtPrefix object at 0x7fcdab3b1c50> api_v4 = <ovirtsdk4.Connection object at 0x7fcdaa85c9d0> @versioning.require_version(4, 2) def test_use_ovn_provider(prefix, api_v4): engine = api_v4.system_service() engine_ip = prefix.virt_env.engine_vm().ip() provider_id = network_utils_v4.get_default_ovn_provider_id(engine) > token_id = _get_auth_token(engine_ip) ../basic-suite-master/test-scenarios/098_ovirt_provider_ovn_pytest.py:444: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ engine_name = '192.168.201.4' def _get_auth_token(engine_name): response_json = _request_auth_token(engine_name) > token_id = response_json['access']['token']['id'] E KeyError: 'access' ../basic-suite-master/test-scenarios/098_ovirt_provider_ovn_pytest.py:105: KeyError Is there a chance that it's due to my patch? > > -- > To view, visit https://gerrit.ovirt.org/109734 This patch runs initial setup with FQDN 'oldenginename', then runs rename with fqdn 'engine'. Above check-patch ran with whatever that was in the repos at the time. I also ran it with the manual job, only basic-suite-master, and the CI-built results of my then-pending patches, and it passed. This was yesterday. I then merged all patches, and now rebased this (OST) patch, to test again, still did not finish: https://jenkins.ovirt.org/job/ovirt-system-tests_standard-check-patch/9894/ That said, even if it passes, I am still not completely ok with my patches. What needs to be done to comprehensively test OVN (with or without rename)? If network suite passes, is this enough? Thanks, -- Didi