If you want to see the files I have changed then they are as same as done in this push https://gerrit.ovirt.org/#/c/63097/. On 23 May 2017 12:36 a.m., "shubham dubey" <sdubey504@gmail.com> wrote:
No, my changes are related to storage domain (adding new flag in storage domain db entries). I have done some changes in unit tests dao files to test those changes only but nothing related to icon.
On 23 May 2017 12:14 a.m., "Greg Sheremeta" <gshereme@redhat.com> wrote:
On Mon, May 22, 2017 at 2:34 PM, shubham dubey <sdubey504@gmail.com> wrote:
I have done some changes
What did you change?
in ovirt-engine now while compiling I am getting following error in file VmIconDaoTest.
Tests run: 13, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 2.466 sec <<< FAILURE! testGetVmIconByDataUrlWithValidUrl(org.ovirt.engine.core.dao.VmIconDaoTest) Time elapsed: 18 sec <<< FAILURE! java.lang.AssertionError: expected:<1> but was:<0> at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:834) at org.junit.Assert.assertEquals(Assert.java:645) at org.junit.Assert.assertEquals(Assert.java:631) at org.ovirt.engine.core.dao.VmIconDaoTest.testGetVmIconByDataU rlWithValidUrl(VmIconDaoTest.java:59) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAcce ssorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMe thodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall( FrameworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(Refl ectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(Fr ameworkMethod.java:47) at org.junit.internal.runners.statements.InvokeMethod.evaluate( InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(Ru nBefores.java:26) at org.springframework.test.context.junit4.statements.RunBefore TestMethodCallbacks.evaluate(RunBeforeTestMethodCallbacks.java:75) at org.springframework.test.context.junit4.statements.RunAfterT estMethodCallbacks.evaluate(RunAfterTestMethodCallbacks.java:86) at org.springframework.test.context.junit4.statements.SpringRep eat.evaluate(SpringRepeat.java:84) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) at org.springframework.test.context.junit4.SpringJUnit4ClassRun ner.runChild(SpringJUnit4ClassRunner.java:254) at org.springframework.test.context.junit4.SpringJUnit4ClassRun ner.runChild(SpringJUnit4ClassRunner.java:89) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java: 71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java :288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java: 58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java: 268) at org.junit.internal.runners.statements.RunBefores.evaluate(Ru nBefores.java:26) at org.springframework.test.context.junit4.statements.RunBefore TestClassCallbacks.evaluate(RunBeforeTestClassCallbacks.java:61) at org.springframework.test.context.junit4.statements.RunAfterT estClassCallbacks.evaluate(RunAfterTestClassCallbacks.java:70) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.springframework.test.context.junit4.SpringJUnit4ClassRun ner.run(SpringJUnit4ClassRunner.java:193) at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUni t4Provider.java:252) at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestS et(JUnit4Provider.java:141) at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit 4Provider.java:112) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAcce ssorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMe thodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodW ithArray(ReflectionUtils.java:189) at org.apache.maven.surefire.booter.ProviderFactory$ProviderPro xy.invoke(ProviderFactory.java:165) at org.apache.maven.surefire.booter.ProviderFactory.invokeProvi der(ProviderFactory.java:85) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInPro cess(ForkedBooter.java:115) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBoo ter.java:75)
... ... Failed tests: testGetVmIconByDataUrlWithVali dUrl(org.ovirt.engine.core.dao.VmIconDaoTest): expected:<1> but was:<0>
I haven't even done any change in VmIconDaoTest file but this error is there. I even try to change the value result.get(0) to result.get(1) in testGetVmIconByDataUrlWithValidUrl but that didn't work.
This is a "unit test." It's rare that you'd want to change it. Its purpose it to inform you that you've probably broken something somewhere else -- likely in the very thing this test is testing, aka the "unit." By the test that's failing, I'd guess that you've changed some code around the Icons feature.
Greg
Thanks in advance.
Shubham
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
-- Greg Sheremeta, MBA Sr. Software Engineer Red Hat, Inc. gshereme@redhat.com