Re: [Engine-devel] LOCALFS path validation

Hi Pahim, Thanks for the input! Comments inline. Thanks, Gilad. ----- Original Message ----- > From: "Amador pahim"<apahim(a)redhat.com> > To: engine-devel(a)ovirt.org > Sent: Monday, May 21, 2012 5:52:34 PM > Subject: [Engine-devel] LOCALFS path validation > > > Hello, > > I'm starting to know the engine code. I chose a little unstandardized > behaviour to follow through the devel process. I have a patch and > I'd like to know if you fell relevant to correct this issue: > > - Description: Adding a LOCAL storage [1], webadmin does not validate > path against regex, sendind the invalid path (with final slash) to > vdsm [2] [3]. But, adding a NFS storage, the path is validated > before contacting vdsm [4] avoiding extra vdsm processing and > quickly/clearly informing user about what's wrong. > > - Expected result: Same behaviour to NFS and LOCALFS storage path > validation. Validate LOCALFS path in webadmin before send it to vdsm > [5]. you may and should send a patch :) > > - Newbie doubt: Wouldn't be better to validate the both local and nfs > path on the backend, achieving all user interfaces/APIs? Because we have a rich client app (gwt), we can perform the validation also in the client side very easily, we do that to avoid unnecessary calls to the backend side, and to have a better& responsive ui (client side validation is performed instantly - without the need to wait). Anyway, every validation performed in the client side needs to be performed also in backend side (for api, and other reasons (security?)).