On Tue, Jan 10, 2017 at 6:43 PM, Vojtech Szocs <vszocs@redhat.com> wrote:
From: "Martin Perina" <mperina@redhat.com> To: "Vojtech Szocs" <vszocs@redhat.com> Cc: "devel" <devel@ovirt.org>, "Juan Hernández" <jhernand@redhat.com> Sent: Friday, January 6, 2017 10:14:22 PM Subject: Re: [ovirt-devel] PatternFly upgrade - how to handle JS dependencies
On Fri, Jan 6, 2017 at 6:45 PM, Vojtech Szocs <vszocs@redhat.com> wrote:
Hello,
we'd like to upgrade the version of PatternFly (plus associated
namely Bootstrap and jQuery) used in oVirt UI.
Today, PatternFly stuff (PF + associated libraries) comes from `patternfly1` package hosted at Copr repo:
https://copr.fedorainfracloud.org/coprs/patternfly/patternfly1/
Today, we require `patternfly1` as both Engine RPM build dependency and the Engine devel. env. dependency.
To keep things simple, I'd like to propose the following approach:
- create oVirt specific package, e.g. `ovirt-patternfly`, hosted at Copr, containing PatternFly + associated libraries (Bootstrap, jQuery) which are intended *specifically* for use by oVirt UI (hence the ovirt
- discontinue maintenance of `patternfly1` package at Copr
- keep the existing approach: require `ovirt-patternfly` as both the
Engine
build dependency and the Engine devel. env. dependency
+1 from me.
The only issue is that we combine several javascript libraries in a
----- Original Message ----- libraries, prefix) package
named ovirt-patternfly.
Well, this is the same approach like with ovirt-engine-nodejs-modules, with a difference that nodejs-modules is intended for build-time only.
The proposed `ovirt-patternfly` (or whatever it's called) is intended for Engine run-time + as Engine devel. env. pre-requisite.
The idea is to bundle all JS/CSS/etc. files required by $PROJECT into a single package. In case of `ovirt-patternfly`, $PROJECT == Engine.
Is there a high probabily that we will need some other javascript libraries in near future?
Not too likely, but there's always the chance.
If so, then I'd rather call the package ovirt-javascript-dependencies (or ovirt-js-dependencies).
OK, maybe even putting `engine` in the name, since we actually need it for the Engine (GWT UI), e.g. `ovirt-engine-ui-dependencies`.
AFAIK new user portal is called ovirt-web-ui so term engine is really not needed in package name :-)
An alternative approach would be to introduce Node.js as Engine devel.
dependency (use `npm install` to pull PF stuff), while using the existing ovirt-engine-{nodejs,nodejs-modules} packages for Engine RPM build.
However, this alternative has some downsides, namely complication of devel. env. just to fetch the PF stuff. I don't like the idea of complicating
env. the
existing devel. env. just for the sake of fetching some 3rd party libs.
I'm wondering what others think about this.
Regards, Vojtech _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel