Re: [ovirt-devel] Creating a new gerrit flag

From: "David Caro" <dcaroest(a)redhat.com&gt; To: "Oved Ourfali" <ovedo(a)redhat.com&gt; Cc: infra(a)ovirt.org, devel(a)ovirt.org Sent: Tuesday, December 9, 2014 12:12:19 PM Subject: Re: [ovirt-devel] Creating a new gerrit flag On 12/09, Oved Ourfali wrote: > What happens when rebasing? > We can't afford waiting for tests to run on each rebase... as we might end > up rebasing forever. For now we will have to, all the code that is going to be merged must be tested as it is going to be merged, that means running the tests in the last rebase too. In the future there are plans on using a gating system like zuul, so zuul will be the one monitoring the tests and merging when passes, so you will just add the flag, and that will trigger the gate, that runs the tests and merged the patch. It's unlikely that you'll have to wait forever, but there's nothing avoiding you doing that (right now even). I'd like to put emphasis again on differentiating between tests that are fast, that should run on each patch and tests that are slow, that should run on each merge. That will improve the feedback times.

> > ----- Original Message ----- > > From: "David Caro" <dcaroest(a)redhat.com&gt; > > To: devel(a)ovirt.org, infra(a)ovirt.org > > Sent: Tuesday, December 9, 2014 11:43:04 AM > > Subject: [ovirt-devel] Creating a new gerrit flag > > > > Hi! > > > > e have been having an issue with gerrit patches being merged before > > jenkins ran any tests on them, to avoid it from happening again I > > propose creating a new gerrit flag (Tests) with the following > > specifics: > > > > > > +1 - Tests passed/overrided > > 0 - Tests pending > > -1 - Tests broken > > > > where +1 is required to submit, +1 is set by jenkins when > > passing the tests and -1 is set by jenkins in case it breaks any > > tests. The +1 flag can be set also by maintainers to allow overriding > > the process. > > > > That way all the tests will be blocked until someone (hopefully > > jenkins) adds the +1 flag, but if the maintainer wants to override the > > value, she just has to set that flag herself. > > > > > > What do you think? > > > > > > -- > > David Caro > > > > Red Hat S.L. > > Continuous Integration Engineer - EMEA ENG Virtualization R&D > > > > Tel.: +420 532 294 605 > > Email: dcaro(a)redhat.com > > Web: www.redhat.com > > RHT Global #: 82-62605 > > > > _______________________________________________ > > Devel mailing list > > Devel(a)ovirt.org > > http://lists.ovirt.org/mailman/listinfo/devel -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Tel.: +420 532 294 605 Email: dcaro(a)redhat.com Web: www.redhat.com RHT Global #: 82-62605 _______________________________________________ Devel mailing list Devel(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/devel