On 09/04/12 11:42, Roy Golan wrote:
auto-detection featured few bugs lately which convinced me that it must be deprecated/removed from the code in favor of adding manual set of the provider type.
main reasons for that: a. the provider is type is known by the user b. identifying a provider by the rootDSE attributes is error-prone, not reliable etc... specially if the support matrix is growing c. auto-detection logic is duplicated (and not shared) between the backend code and the manage-domains tool (nevermind the reasons now)
+1 for removing this 'feature'
A manual set of the provider type requires a new configuration field for a domain and the question is the upgrade path which may look like
* set the provider type to default Active Directory (because its more likely to be the provider type) * things not working - use the engine-manage-domains and choose the provider type.
* optionally - keep the auto-detection (of the tool only!) if user wants to use it.
I think we should require that the user specifies the provider type (from now on), and enable editing this field of course. Another upgrade proposal is to populate the provider type only upon the first time we need to use this domain (and it is not populated) by using the current 'auto-detect' mechanism. By taking the above approach we don't break behavior for the user and we enable manually fixing of the domain provider type (which is a bypass for all current bugs in the auto-detect). Livnat
your suggestion and thoughts...
Thanks, Roy
_______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel