----- Original Message -----
From: "Yaniv Bronheim" <ybronhei@redhat.com> To: "devel" <devel@ovirt.org>, "Shahar Havivi" <shavivi@redhat.com>, "Francesco Romani" <fromani@redhat.com>, "Nir Soffer" <nsoffer@redhat.com> Sent: Monday, January 18, 2016 11:01:10 AM Subject: Ensure processes death by terminating decorator - https://gerrit.ovirt.org/51407
Hi guys,
Following the work to omit deathSignal attribute from our cpopen implementation we posted https://gerrit.ovirt.org/51407 which is ready for use. Currently locations that should use it are: (I wrote above who I expect to check the area and post a patch for that - we'll discuss it during next vdsm-sync to follow the work)
fromani: vdsm_hooks/checkimages/before_vm_start.py - in checkImage - the code looks ok, but check if not better to use the terminating decorator.. I think it will be nicer
Fair enough, posted https://gerrit.ovirt.org/52349
some places define deathSignal for no reason, the call is sync - please remove those places: [...] fromani: lib/vdsm/virtsparsify.py
Done in https://gerrit.ovirt.org/52357 -- Francesco Romani RedHat Engineering Virtualization R & D Phone: 8261328 IRC: fromani