
----- Original Message -----
From: "Vojtech Szocs" <vszocs@redhat.com> To: "Greg Sheremeta" <gshereme@redhat.com> Cc: devel@ovirt.org, "Alexander Wels" <awels@redhat.com> Sent: Thursday, June 5, 2014 9:26:19 AM Subject: Re: jQuery?
----- Original Message -----
From: "Greg Sheremeta" <gshereme@redhat.com> To: devel@ovirt.org Cc: "Alexander Wels" <awels@redhat.com>, "Vojtech Szocs" <vszocs@redhat.com> Sent: Wednesday, June 4, 2014 3:19:23 AM Subject: jQuery?
Does anyone see an issue with adding jQuery to GwtHostPage? Some PatternFly widgets require bootstrap.min.js which requires jQuery.
My understanding is that PatternFly is essentially a "skin" of Bootstrap CSS, which doesn't imply the need for using Bootstrap _JavaScript_ library (which needs jQuery) to deal with widgets in JavaScript runtime.
Any JavaScript-enabled widgets (like tooltips) do require bootstrap.js and jquery.js. The only reason I didn't add them in the main PatternFly patch is that we didn't need them back then. But now we need them.
I thought that the purpose of "gwtbootstrap3" GWT module (integration with Bootstrap CSS framework) was to provide such widgets in context of GWT app. If not, what is then the purpose of "gwtbootstrap3" module?
gwtbootstrap3 provides renderings of GWT widgets that are compatible with bootstrap css. It does not rewrite the jQuery code into GWT-JavaScript code.
In other words, doesn't "gwtbootstrap3" module provide us with all widgets we need?
I wouldn't say "provide." It enables using the widgets more easily from GWT. Take a look at https://github.com/gwtbootstrap3/gwtbootstrap3/blob/master/gwtbootstrap3/src... line 521 on down. It simply wraps everything for ease-of-use from GWT / UIBinder. Greg
Thanks, Greg
Greg Sheremeta Red Hat, Inc. Sr. Software Engineer, RHEV Cell: 919-807-1086 gshereme@redhat.com